From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: gpu: nova-core: vbios: use checked accesses in `setup_falcon_data`
Date: Thu, 23 Apr 2026 08:42:24 +1000 [thread overview]
Message-ID: <review-patch5-20260421-fix-vbios-v3-5-8f648aef7a85@nvidia.com> (raw)
In-Reply-To: <20260421-fix-vbios-v3-5-8f648aef7a85@nvidia.com>
Patch Review
Good fix. The old code:
```rust
let mut ucode_offset = usize::from_safe_cast(entry.data);
ucode_offset -= pci_at_image.base.data.len();
// check and subtract...
ucode_offset -= first_fwsec.base.data.len();
```
could panic on the subtractions if the firmware-supplied `entry.data` was smaller than expected. The new code chains `checked_sub` calls and returns `EINVAL` on underflow.
No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-22 22:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-21 8:20 [PATCH v3 00/11] gpu: nova-core: vbios: harden various array accesses and refactor Eliot Courtney
2026-04-21 8:20 ` [PATCH v3 01/11] gpu: nova-core: vbios: fix various cases of reading past `BIOS_MAX_SCAN_LEN` Eliot Courtney
2026-04-22 22:42 ` Claude review: " Claude Code Review Bot
2026-04-21 8:20 ` [PATCH v3 02/11] gpu: nova-core: vbios: limit `BitToken` entry reads Eliot Courtney
2026-04-22 22:42 ` Claude review: " Claude Code Review Bot
2026-04-21 8:20 ` [PATCH v3 03/11] gpu: nova-core: vbios: use checked ops and accesses in `FwSecBiosImage::ucode` Eliot Courtney
2026-04-22 22:42 ` Claude review: " Claude Code Review Bot
2026-04-21 8:20 ` [PATCH v3 04/11] gpu: nova-core: vbios: use checked access in `FwSecBiosImage::header` Eliot Courtney
2026-04-22 22:42 ` Claude review: " Claude Code Review Bot
2026-04-21 8:20 ` [PATCH v3 05/11] gpu: nova-core: vbios: use checked accesses in `setup_falcon_data` Eliot Courtney
2026-04-22 22:42 ` Claude Code Review Bot [this message]
2026-04-21 8:20 ` [PATCH v3 06/11] gpu: nova-core: vbios: drop unused falcon_data_offset from FwSecBiosBuilder Eliot Courtney
2026-04-22 22:42 ` Claude review: " Claude Code Review Bot
2026-04-21 8:20 ` [PATCH v3 07/11] gpu: nova-core: vbios: keep PmuLookupTable local in setup_falcon_data Eliot Courtney
2026-04-22 22:42 ` Claude review: " Claude Code Review Bot
2026-04-21 8:20 ` [PATCH v3 08/11] gpu: nova-core: vbios: compute FWSEC-relative Falcon data offset Eliot Courtney
2026-04-22 22:42 ` Claude review: " Claude Code Review Bot
2026-04-21 8:20 ` [PATCH v3 09/11] gpu: nova-core: vbios: simplify setup_falcon_data Eliot Courtney
2026-04-22 22:42 ` Claude review: " Claude Code Review Bot
2026-04-21 8:20 ` [PATCH v3 10/11] gpu: nova-core: vbios: construct `FwSecBiosImage` directly from BIOS images Eliot Courtney
2026-04-22 22:42 ` Claude review: " Claude Code Review Bot
2026-04-21 8:20 ` [PATCH v3 11/11] gpu: nova-core: vbios: use the first PCI-AT and FWSEC images Eliot Courtney
2026-04-22 22:42 ` Claude review: " Claude Code Review Bot
2026-04-22 22:42 ` Claude review: gpu: nova-core: vbios: harden various array accesses and refactor Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-10 8:38 [PATCH 0/5] gpu: nova-core: vbios: harden various array accesses Eliot Courtney
2026-04-10 8:38 ` [PATCH 3/5] gpu: nova-core: vbios: use checked accesses in `setup_falcon_data` Eliot Courtney
2026-04-12 0:18 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260421-fix-vbios-v3-5-8f648aef7a85@nvidia.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox