From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vmwgfx: Remove duplicates in vmwgfx_bo.h
Date: Sat, 16 May 2026 14:26:31 +1000 [thread overview]
Message-ID: <review-patch5-20260512002752.2826685-6-maaz.mombasawala@broadcom.com> (raw)
In-Reply-To: <20260512002752.2826685-6-maaz.mombasawala@broadcom.com>
Patch Review
**Confirmed the functions are truly identical.** Both `vmw_user_bo_ref`/`vmw_bo_reference` call `drm_gem_object_get`, and both `vmw_user_bo_unref`/`vmw_bo_unreference` null the pointer then call `drm_gem_object_put`. The removal is correct.
**Also removes a duplicate `struct vmw_bo;` forward declaration** in `vmwgfx_drv.h`:
```c
struct vmw_bo;
-struct vmw_bo;
```
Good cleanup.
**This is a straightforward mechanical substitution** across 11 files. The patch is clean and complete — all callers are updated. This should be the lowest-risk patch in the series, but it would be better placed first or second in the series to avoid depending on patches 3/4's changes to the same files.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 4:26 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-12 0:27 [PATCH v2 0/5] Fix some issues from igt runs Maaz Mombasawala
2026-05-12 0:27 ` [PATCH v2 1/5] drm/vmwgfx: Add some checks to vmw_cursor_plane_atomic_update Maaz Mombasawala
2026-05-16 4:26 ` Claude review: " Claude Code Review Bot
2026-05-12 0:27 ` [PATCH v2 2/5] drm/vmwgfx: Check vrefresh in drm_mode_setcrtc Maaz Mombasawala
2026-05-16 4:26 ` Claude review: " Claude Code Review Bot
2026-05-12 0:27 ` [PATCH v2 3/5] drm/vmwgfx: Reserve ttm object before resv usage Maaz Mombasawala
2026-05-16 4:26 ` Claude review: " Claude Code Review Bot
2026-05-12 0:27 ` [PATCH v2 4/5] drm/vmwgfx: Change ttm refs for dumb buffers Maaz Mombasawala
2026-05-16 4:26 ` Claude review: " Claude Code Review Bot
2026-05-12 0:27 ` [PATCH v2 5/5] drm/vmwgfx: Remove duplicates in vmwgfx_bo.h Maaz Mombasawala
2026-05-16 4:26 ` Claude Code Review Bot [this message]
2026-05-16 4:26 ` Claude review: Fix some issues from igt runs Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-14 22:48 [PATCH v3 0/5] " Maaz Mombasawala
2026-05-14 22:48 ` [PATCH v3 5/5] drm/vmwgfx: Remove duplicates in vmwgfx_bo.h Maaz Mombasawala
2026-05-16 0:17 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260512002752.2826685-6-maaz.mombasawala@broadcom.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox