From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vmwgfx: Remove duplicates in vmwgfx_bo.h
Date: Sat, 16 May 2026 10:17:50 +1000 [thread overview]
Message-ID: <review-patch5-20260514224819.3631763-6-maaz.mombasawala@broadcom.com> (raw)
In-Reply-To: <20260514224819.3631763-6-maaz.mombasawala@broadcom.com>
Patch Review
**Straightforward and correct cleanup.** The removed functions:
```c
-static inline struct vmw_bo *vmw_user_bo_ref(struct vmw_bo *vbo)
-{
- drm_gem_object_get(&vbo->tbo.base);
- return vbo;
-}
-
-static inline void vmw_user_bo_unref(struct vmw_bo **buf)
-{
- struct vmw_bo *tmp_buf = *buf;
-
- *buf = NULL;
- if (tmp_buf)
- drm_gem_object_put(&tmp_buf->tbo.base);
-}
```
These are indeed identical to `vmw_bo_reference` and `vmw_bo_unreference`. All callers are mechanically updated. The duplicate `struct vmw_bo;` forward declaration removal in `vmwgfx_drv.h` is a nice bonus cleanup.
One concern: this patch touches files also touched by patch 4 (`vmwgfx_surface.c`). The series should apply cleanly in order, but it would be worth confirming that the `vmwgfx_surface.c` changes in patch 5 are based on the state after patch 4 (they appear to be, since line numbers differ).
**Summary:** The series fixes real bugs. The main concerns are the coding style in patch 1 (declarations after statements, double space), the safety of `ttm_bo_reserve` on a zero-refcount BO in patch 3, and ensuring the TTM reference lifetime change in patch 4 doesn't introduce a new leak path. Patch 2 and 5 look good.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 0:17 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-14 22:48 [PATCH v3 0/5] Fix some issues from igt runs Maaz Mombasawala
2026-05-14 22:48 ` [PATCH v3 1/5] drm/vmwgfx: Add some checks to vmw_cursor_plane_atomic_update Maaz Mombasawala
2026-05-16 0:17 ` Claude review: " Claude Code Review Bot
2026-05-14 22:48 ` [PATCH v3 2/5] drm/vmwgfx: Check vrefresh in drm_mode_setcrtc Maaz Mombasawala
2026-05-16 0:17 ` Claude review: " Claude Code Review Bot
2026-05-14 22:48 ` [PATCH v3 3/5] drm/vmwgfx: Reserve ttm object before resv usage Maaz Mombasawala
2026-05-16 0:17 ` Claude review: " Claude Code Review Bot
2026-05-14 22:48 ` [PATCH v3 4/5] drm/vmwgfx: Change ttm refs for dumb buffers Maaz Mombasawala
2026-05-15 5:49 ` Zack Rusin
2026-05-16 0:17 ` Claude review: " Claude Code Review Bot
2026-05-14 22:48 ` [PATCH v3 5/5] drm/vmwgfx: Remove duplicates in vmwgfx_bo.h Maaz Mombasawala
2026-05-16 0:17 ` Claude Code Review Bot [this message]
2026-05-16 0:17 ` Claude review: Fix some issues from igt runs Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-12 0:27 [PATCH v2 0/5] " Maaz Mombasawala
2026-05-12 0:27 ` [PATCH v2 5/5] drm/vmwgfx: Remove duplicates in vmwgfx_bo.h Maaz Mombasawala
2026-05-16 4:26 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch5-20260514224819.3631763-6-maaz.mombasawala@broadcom.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox