From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: phy: freescale: Add DisplayPort/HDMI Combo-PHY driver for i.MX8MQ
Date: Sun, 12 Apr 2026 13:34:46 +1000 [thread overview]
Message-ID: <review-patch6-20260407-dcss-hdmi-upstreaming-v21-6-4681070ab82f@oss.nxp.com> (raw)
In-Reply-To: <20260407-dcss-hdmi-upstreaming-v21-6-4681070ab82f@oss.nxp.com>
Patch Review
**Resource mapping should use `devm_platform_ioremap_resource()`:**
```c
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res)
return -ENODEV;
cdns_phy->regs = devm_ioremap(dev, res->start, resource_size(res));
```
This is the old pattern. Modern drivers use the simpler `devm_platform_ioremap_resource(pdev, 0)` which handles the NULL check and does `devm_ioremap_resource` (which also does request_region). The same issue exists in the bridge probe in patch 4.
**`hdptx_clk_enable` error handling:**
```c
ret = hdptx_clk_enable(cdns_phy);
if (ret)
return -EINVAL;
```
This discards the actual error code from `hdptx_clk_enable`. Should be `return ret;`.
**Missing `phy_exit()` on error and remove paths**: `phy_init()` is not called in the PHY driver itself (that's the consumer's responsibility), so this is fine, but the clocks enabled in probe are never disabled — `devm_clk_get_enabled` handles this via devm, so it's correct.
**Large PLL configuration tables**: The 32-entry `pixel_clk_output_ctrl_table` and 15-entry `pixel_clk_output_pll_table` are quite large. Consider whether they belong in a separate data file, but this is a style preference.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 3:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 14:31 [PATCH v21 0/8] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ Laurentiu Palcu
2026-04-07 14:31 ` [PATCH v21 1/8] soc: cadence: Create helper functions for Cadence MHDP Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-07 14:31 ` [PATCH v21 2/8] drm: bridge: cadence: Update mhdp8546 mailbox access functions Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-07 14:31 ` [PATCH v21 3/8] dt-bindings: display: bridge: Add Cadence MHDP8501 Laurentiu Palcu
2026-04-08 6:42 ` Krzysztof Kozlowski
2026-04-08 7:13 ` Laurentiu Palcu
2026-04-08 7:32 ` Krzysztof Kozlowski
2026-04-08 14:36 ` Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-07 14:31 ` [PATCH v21 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-07 14:31 ` [PATCH v21 5/8] dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-07 14:31 ` [PATCH v21 6/8] phy: freescale: Add DisplayPort/HDMI Combo-PHY driver for i.MX8MQ Laurentiu Palcu
2026-04-12 3:34 ` Claude Code Review Bot [this message]
2026-04-07 14:31 ` [PATCH v21 7/8] arm64: dts: imx8mq: Add DCSS + HDMI/DP display pipeline Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-07 14:31 ` [PATCH v21 8/8] arm64: dts: imx8mq: tqma8mq-mba8mx: Enable HDMI support Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-08 6:38 ` [PATCH v21 0/8] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ Krzysztof Kozlowski
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch6-20260407-dcss-hdmi-upstreaming-v21-6-4681070ab82f@oss.nxp.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox