From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dt-bindings: display: bridge: Add Cadence MHDP8501
Date: Sun, 12 Apr 2026 13:34:45 +1000 [thread overview]
Message-ID: <review-patch3-20260407-dcss-hdmi-upstreaming-v21-3-4681070ab82f@oss.nxp.com> (raw)
In-Reply-To: <20260407-dcss-hdmi-upstreaming-v21-3-4681070ab82f@oss.nxp.com>
Patch Review
**`cdns,bridge-type` property concern:**
```yaml
cdns,bridge-type:
$ref: /schemas/types.yaml#/definitions/uint32
enum: [0, 1]
description: |
Type of bridge output:
0: DisplayPort
1: HDMI
```
Using a vendor-specific integer property to specify bridge type is questionable. The connector type should ideally be determined by the downstream port's compatible (e.g., `hdmi-connector` vs `dp-connector`). The cover letter mentions "I couldn't find another way to do it..." — the bridge should be able to discover this from its output port graph connection. This was also flagged in previous reviews by Dmitry.
**Missing `Reviewed-by` tags**: No dt-bindings maintainer review tag. Krzysztof's tag was dropped since a new property was added.
**Nit in example DTS:**
```yaml
phys = <&mdhp_phy>;
```
The phandle `mdhp_phy` has a typo (should be `mhdp_phy`, matching standard MHDP naming). This same typo propagates to patch 7.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-04-12 3:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 14:31 [PATCH v21 0/8] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ Laurentiu Palcu
2026-04-07 14:31 ` [PATCH v21 1/8] soc: cadence: Create helper functions for Cadence MHDP Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-07 14:31 ` [PATCH v21 2/8] drm: bridge: cadence: Update mhdp8546 mailbox access functions Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-07 14:31 ` [PATCH v21 3/8] dt-bindings: display: bridge: Add Cadence MHDP8501 Laurentiu Palcu
2026-04-08 6:42 ` Krzysztof Kozlowski
2026-04-08 7:13 ` Laurentiu Palcu
2026-04-08 7:32 ` Krzysztof Kozlowski
2026-04-08 14:36 ` Laurentiu Palcu
2026-04-12 3:34 ` Claude Code Review Bot [this message]
2026-04-07 14:31 ` [PATCH v21 4/8] drm: bridge: Cadence: Add MHDP8501 DP/HDMI driver Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-07 14:31 ` [PATCH v21 5/8] dt-bindings: phy: Add Freescale iMX8MQ DP and HDMI PHY Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-07 14:31 ` [PATCH v21 6/8] phy: freescale: Add DisplayPort/HDMI Combo-PHY driver for i.MX8MQ Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-07 14:31 ` [PATCH v21 7/8] arm64: dts: imx8mq: Add DCSS + HDMI/DP display pipeline Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-07 14:31 ` [PATCH v21 8/8] arm64: dts: imx8mq: tqma8mq-mba8mx: Enable HDMI support Laurentiu Palcu
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
2026-04-08 6:38 ` [PATCH v21 0/8] Initial support Cadence MHDP8501(HDMI/DP) for i.MX8MQ Krzysztof Kozlowski
2026-04-12 3:34 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260407-dcss-hdmi-upstreaming-v21-3-4681070ab82f@oss.nxp.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox