public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/tyr: Add DOORBELL_BLOCK registers
Date: Sun, 12 Apr 2026 10:45:09 +1000	[thread overview]
Message-ID: <review-patch6-20260409-b4-tyr-use-register-macro-v5-v5-6-8abfff8a0204@collabora.com> (raw)
In-Reply-To: <20260409-b4-tyr-use-register-macro-v5-v5-6-8abfff8a0204@collabora.com>

Patch Review

Adds definitions for the doorbell register array.

```rust
pub(crate) const NUM_DOORBELLS: usize = 64;
const STRIDE: usize = 0x10000;

register! {
    pub(crate) DOORBELL(u32)[NUM_DOORBELLS, stride = STRIDE] @ 0x80000 {
        0:0    ring => bool;
    }
}
```

64 doorbells at 64KiB stride starting at 0x80000. Each doorbell block occupies a full page to allow per-doorbell memory mapping. The single `ring` bit is write-only (documented in the comment). This is forward-looking infrastructure for future CSF support.

No issues.

---

**Summary:** The series is in good shape. The main actionable item is that the `L2_PWRTRANS_HI` offset fix (0x204 -> 0x224) in patch 1 should be called out explicitly in the commit message since it fixes a real bug, not just a naming issue. The rest is clean, well-documented, and correct against the panthor C reference.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-04-12  0:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-09 17:51 [PATCH v5 0/6] drm/tyr: Use register! macro Deborah Brouwer
2026-04-09 17:51 ` [PATCH v5 1/6] drm/tyr: Use register! macro for GPU_CONTROL Deborah Brouwer
2026-04-12  0:45   ` Claude review: " Claude Code Review Bot
2026-04-09 17:51 ` [PATCH v5 2/6] drm/tyr: Print GPU_ID without filtering Deborah Brouwer
2026-04-12  0:45   ` Claude review: " Claude Code Review Bot
2026-04-09 17:51 ` [PATCH v5 3/6] drm/tyr: Use register! macro for JOB_CONTROL Deborah Brouwer
2026-04-12  0:45   ` Claude review: " Claude Code Review Bot
2026-04-09 17:51 ` [PATCH v5 4/6] drm/tyr: Use register! macro for MMU_CONTROL Deborah Brouwer
2026-04-12  0:45   ` Claude review: " Claude Code Review Bot
2026-04-09 17:51 ` [PATCH v5 5/6] drm/tyr: Remove custom register struct Deborah Brouwer
2026-04-12  0:45   ` Claude review: " Claude Code Review Bot
2026-04-09 17:51 ` [PATCH v5 6/6] drm/tyr: Add DOORBELL_BLOCK registers Deborah Brouwer
2026-04-12  0:45   ` Claude Code Review Bot [this message]
2026-04-12  0:45 ` Claude review: drm/tyr: Use register! macro Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-03-24  0:18 [PATCH v3 00/12] " Deborah Brouwer
2026-03-24  0:18 ` [PATCH v3 12/12] drm/tyr: Add DOORBELL_BLOCK registers Deborah Brouwer
2026-03-24 21:08   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch6-20260409-b4-tyr-use-register-macro-v5-v5-6-8abfff8a0204@collabora.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox