Claude review: zorro: Simplify storing pointers in device id struct

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Status: Looks good.**

The core change in `include/linux/mod_devicetable.h`:

```c
 struct zorro_device_id {
 	__u32 id;			/* Device ID or ZORRO_WILDCARD */
-	kernel_ulong_t driver_data;	/* Data private to the driver */
+	union {
+		/* Data private to the driver */
+		kernel_ulong_t driver_data;
+		const void *driver_data_ptr;
+	};
 };
```

This is clean and backward compatible. Key observations:

1. **Union sizing:** `kernel_ulong_t` is `unsigned long long` on 32-bit arches (for cross-compilation with file2alias), so the union is at least 8 bytes. On all current architectures, `sizeof(void *)` <= `sizeof(kernel_ulong_t)`, so the union doesn't change struct size or layout. On CHERI, pointers would be larger, but that's exactly the scenario this enables.

2. **Anonymous union:** Correct choice — it allows `ent->driver_data` and `ent->driver_data_ptr` to be used interchangeably without changing any syntax at call sites.

3. **Backward compatibility:** All existing users that set `.driver_data = (unsigned long)&foo` continue to compile and work. The patches 7 and 8 then convert them to `.driver_data_ptr` at their own pace. This is the right incremental approach.

4. **const correctness:** Using `const void *` is appropriate — it preserves const-ness of the pointed-to data, which the `(unsigned long)` cast was losing.

One minor note: the commit message says "no adaptions are needed" for existing users — this is correct because all current initializers use `.driver_data = ...` named syntax or positional syntax that maps to `.id` (the first field), and `driver_data` remains accessible at the same name.

No concerns.

---
Generated by Claude Code Patch Reviewer