Claude review: zorro: Improve handling of pointers in zorro_device_id::driver_data

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: zorro: Improve handling of pointers in zorro_device_id::driver_data
Author: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig=20=28The=20Capable=20Hub=29?=
 <u.kleine-koenig@baylibre.com>
Patches: 6
Reviewed: 2026-05-27T14:47:32.957704

---

This is a well-structured cleanup series by Uwe Kleine-König targeting the `zorro_device_id` struct to improve type safety when storing pointers in `driver_data`. The mbox contains only 3 of 8 patches (5, 6, 8) — those relevant to the video/fbdev and the core header change. The remaining patches (1-4, 7) touch ata, scsi, net, and i2c subsystems and were filtered out.

The core idea (patch 6) is sound: replacing `kernel_ulong_t driver_data` with an anonymous union containing both `driver_data` and `const void *driver_data_ptr` eliminates unsafe `(unsigned long)` pointer casts. This is a standard pattern already used in other device ID structs in the kernel (e.g., `platform_device_id`). The motivation — CHERI compatibility — is legitimate, and the cleanup stands on its own merits regardless.

The patches are clean, mechanical, and correct. The anonymous union approach preserves backward compatibility with all existing users. No functional changes are introduced.

**Recommendation:** The series looks good. No correctness issues found.

---
Generated by Claude Code Patch Reviewer