From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/msm/a6xx: Add yield & flush helper
Date: Tue, 05 May 2026 08:06:03 +1000 [thread overview]
Message-ID: <review-patch8-20260504190751.61052-9-robin.clark@oss.qualcomm.com> (raw)
In-Reply-To: <20260504190751.61052-9-robin.clark@oss.qualcomm.com>
Patch Review
**Issue: Behavioral change in preempt_start paths.**
The new `a6xx_flush_yield()` helper hardcodes dword[3] as `0x01`:
```c
OUT_RING(ring, 0x01);
```
But the `a7xx_preempt_start()` and `a8xx_preempt_start()` code that is being replaced used `0x00` for dword[3]:
```c
- OUT_RING(ring, 0x00); /* dword[3] was 0x00 in preempt_start */
```
Meanwhile the `a7xx_submit()` path already used `0x01`. So this refactoring silently changes the preempt_start behavior. The comment says "Data value - not used if the address above is 0" so this is likely benign, but it should either be called out in the commit message as an intentional change, or the helper should accept the data value as a parameter to preserve the original behavior.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 22:06 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-04 19:06 [PATCH v3 00/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-04 19:06 ` [PATCH v3 01/16] drm/msm: Remove obsolete perf infrastructure Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 ` [PATCH v3 02/16] drm/msm: Allow CAP_PERFMON for setting SYSPROF Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 ` [PATCH v3 04/16] drm/msm/registers: Sync gen_header.py from mesa Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 ` [PATCH v3 05/16] drm/msm/registers: Add perfcntr json Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 ` [PATCH v3 06/16] drm/msm: Add a6xx+ perfcntr tables Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 ` [PATCH v3 07/16] drm/msm: Add sysprof accessors Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 ` [PATCH v3 08/16] drm/msm/a6xx: Add yield & flush helper Rob Clark
2026-05-04 22:06 ` Claude Code Review Bot [this message]
2026-05-04 19:06 ` [PATCH v3 09/16] drm/msm: Add per-context perfcntr state Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 ` [PATCH v3 10/16] drm/msm: Add basic perfcntr infrastructure Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 ` [PATCH v3 11/16] drm/msm/a6xx+: Add support to configure perfcntrs Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 ` [PATCH v3 12/16] drm/msm/a8xx: Add perfcntr flush sequence Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 ` [PATCH v3 13/16] drm/msm: Add PERFCNTR_CONFIG ioctl Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 ` [PATCH v3 14/16] drm/msm/a6xx: Increase pwrup_reglist size Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 ` [PATCH v3 15/16] drm/msm/a6xx: Append SEL regs to dyn pwrup reglist Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 19:06 ` [PATCH v3 16/16] drm/msm/a6xx: Allow IFPC with perfcntr stream Rob Clark
2026-05-04 22:06 ` Claude review: " Claude Code Review Bot
2026-05-04 22:06 ` Claude review: drm/msm: Add PERFCNTR_CONFIG ioctl Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-20 22:25 [PATCH 00/13] " Rob Clark
2026-04-20 22:25 ` [PATCH 08/13] drm/msm/a6xx: Add yield & flush helper Rob Clark
2026-04-22 23:13 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch8-20260504190751.61052-9-robin.clark@oss.qualcomm.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox