From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: milos: Add display (MDSS)
Date: Tue, 05 May 2026 09:35:35 +1000 [thread overview]
Message-ID: <review-patch9-20260501-milos-mdss-v3-9-58bfc58c0e13@fairphone.com> (raw)
In-Reply-To: <20260501-milos-mdss-v3-9-58bfc58c0e13@fairphone.com>
Patch Review
Adds the complete MDSS device tree nodes (MDSS, DPU, DSI controller, DSI PHY) to milos.dtsi, and wires up the dispcc clock controller to use the DSI PHY clocks instead of the `<0>` placeholders.
The DTS matches the DT binding example from Patch 4 almost exactly (with expected differences like `#address-cells = <2>` in the actual DTS vs `<1>` in the binding example, and `status = "disabled"` in the actual nodes).
```diff
- <0>, /* dsi0_phy_pll_out_byteclk */
- <0>, /* dsi0_phy_pll_out_dsiclk */
+ <&mdss_dsi0_phy DSI_BYTE_PLL_CLK>,
+ <&mdss_dsi0_phy DSI_PIXEL_PLL_CLK>,
```
This correctly replaces the stub clock references in the display clock controller with the actual DSI PHY PLL outputs. The `dt-bindings/clock/qcom,dsi-phy-28nm.h` include is added for `DSI_BYTE_PLL_CLK` and `DSI_PIXEL_PLL_CLK` constants.
All nodes are `status = "disabled"` by default, to be enabled by board-level DTS files. Has Reviewed-by from Konrad. No issues.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-04 23:35 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-01 7:14 [PATCH v3 0/9] MDSS / DPU bringup for Milos Luca Weiss
2026-05-01 7:14 ` [PATCH v3 1/9] dt-bindings: display: msm-dsi-phy-7nm: document the Milos DSI PHY Luca Weiss
2026-05-04 23:35 ` Claude review: " Claude Code Review Bot
2026-05-01 7:14 ` [PATCH v3 2/9] dt-bindings: display: msm-dsi-controller-main: document the Milos DSI Controller Luca Weiss
2026-05-04 23:35 ` Claude review: " Claude Code Review Bot
2026-05-01 7:14 ` [PATCH v3 3/9] dt-bindings: display: msm: document the Milos DPU Luca Weiss
2026-05-04 23:35 ` Claude review: " Claude Code Review Bot
2026-05-01 7:14 ` [PATCH v3 4/9] dt-bindings: display: msm: document the Milos Mobile Display Subsystem Luca Weiss
2026-05-03 12:28 ` Krzysztof Kozlowski
2026-05-04 23:35 ` Claude review: " Claude Code Review Bot
2026-05-01 7:14 ` [PATCH v3 5/9] soc: qcom: ubwc: Add config for Milos Luca Weiss
2026-05-04 23:35 ` Claude review: " Claude Code Review Bot
2026-05-01 7:14 ` [PATCH v3 6/9] drm/msm/dsi: add support for DSI-PHY on Milos Luca Weiss
2026-05-04 23:35 ` Claude review: " Claude Code Review Bot
2026-05-01 7:14 ` [PATCH v3 7/9] drm/msm: mdss: Add Milos support Luca Weiss
2026-05-04 23:35 ` Claude review: " Claude Code Review Bot
2026-05-01 7:14 ` [PATCH v3 8/9] drm/msm/dpu: " Luca Weiss
2026-05-04 23:35 ` Claude review: " Claude Code Review Bot
2026-05-01 7:14 ` [PATCH v3 9/9] arm64: dts: qcom: milos: Add display (MDSS) Luca Weiss
2026-05-04 23:35 ` Claude Code Review Bot [this message]
2026-05-04 23:35 ` Claude review: MDSS / DPU bringup for Milos Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch9-20260501-milos-mdss-v3-9-58bfc58c0e13@fairphone.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox