public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: soc/tegra: pmc: Move legacy code behind CONFIG_ARM guard
Date: Thu, 07 May 2026 13:29:36 +1000	[thread overview]
Message-ID: <review-patch9-20260506-pmc-v1-9-a6de5da7216b@nvidia.com> (raw)
In-Reply-To: <20260506-pmc-v1-9-a6de5da7216b@nvidia.com>

Patch Review

Moves the remaining legacy functions (`tegra_pmc_cpu_is_powered`, `tegra_pmc_cpu_power_on`, `tegra_pmc_cpu_remove_clamping`, `tegra_pmc_core_domain_state_synced`, and suspend mode functions) behind `#if defined(CONFIG_ARM)` in both `pmc.c` and `pmc.h`.

The `early_pmc` static variable itself is also guarded by `CONFIG_ARM`, and `#if defined(CONFIG_ARM)` blocks are added around the early_pmc usage in `tegra_pmc_probe()`.

The `tegra_pmc_early_init()` function and its `early_initcall()` are also moved behind the CONFIG_ARM guard. This means on arm64, the early init code won't run at all -- which is correct since the dynamic allocation in probe handles everything.

In `pmc.h`, the header is restructured to separate the instance-aware API (guarded by `CONFIG_SOC_TEGRA_PMC`) from the legacy 32-bit-only API (guarded by `CONFIG_ARM`). The suspend mode stubs are now under `CONFIG_ARM && !(CONFIG_SOC_TEGRA_PMC && CONFIG_PM_SLEEP)`. A `COMPILE_TEST` stub for `tegra_pmc_core_domain_state_synced()` is provided for the `!CONFIG_ARM` case.

The `#if defined(CONFIG_ARM)` blocks inside `tegra_pmc_probe()` are a bit ugly (in-function `#ifdef`), but acceptable as a pragmatic solution. An alternative would be a helper function, but the current approach is clear enough.

The cover letter mentions "Changes in v2: fix build issue for ARM && !PM_SLEEP" which only appears in this patch's changelog but is formatted as if it's a per-patch note rather than a series-level note. Minor formatting nit.

No functional issues.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-07  3:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 13:41 [PATCH 0/9] soc/tegra: pmc: Clean up legacy code Thierry Reding
2026-05-06 13:41 ` [PATCH 1/9] ata: ahci_tegra: Explicitly specify PMC instance to use Thierry Reding
2026-05-06 13:54   ` Damien Le Moal
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:41 ` [PATCH 2/9] drm/nouveau: tegra: " Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:41 ` [PATCH 3/9] drm/tegra: " Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:41 ` [PATCH 4/9] media: vde: " Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:41 ` [PATCH 5/9] PCI: tegra: " Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:41 ` [PATCH 6/9] usb: xhci: " Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:41 ` [PATCH 7/9] soc/tegra: pmc: Create PMC context dynamically Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:41 ` [PATCH 8/9] soc/tegra: pmc: Remove unused legacy functions Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:42 ` [PATCH 9/9] soc/tegra: pmc: Move legacy code behind CONFIG_ARM guard Thierry Reding
2026-05-07  3:29   ` Claude Code Review Bot [this message]
2026-05-07  3:29 ` Claude review: soc/tegra: pmc: Clean up legacy code Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch9-20260506-pmc-v1-9-a6de5da7216b@nvidia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox