public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: PCI: tegra: Explicitly specify PMC instance to use
Date: Thu, 07 May 2026 13:29:35 +1000	[thread overview]
Message-ID: <review-patch5-20260506-pmc-v1-5-a6de5da7216b@nvidia.com> (raw)
In-Reply-To: <20260506-pmc-v1-5-a6de5da7216b@nvidia.com>

Patch Review

**Bug:** The error handling in `tegra_pcie_get_resources()` returns a stale `err`:

```c
	pcie->pmc = devm_tegra_pmc_get(dev);
	if (IS_ERR(pcie->pmc)) {
		dev_err_probe(dev, PTR_ERR(pcie->pmc), "failed to get PMC\n");
		return err;
	}
```

This should be `return PTR_ERR(pcie->pmc)`. The variable `err` at this point holds the return value of `tegra_pcie_resets_get()` from earlier, which was 0 (success) -- so on PMC lookup failure, this function would return 0, silently indicating success with `pcie->pmc` set to an error pointer. This will cause an oops the first time `pcie->pmc` is dereferenced in a powergate call.

This needs to be fixed to:
```c
	pcie->pmc = devm_tegra_pmc_get(dev);
	if (IS_ERR(pcie->pmc))
		return dev_err_probe(dev, PTR_ERR(pcie->pmc), "failed to get PMC\n");
```

or equivalently, assign `err = PTR_ERR(pcie->pmc)` before the `dev_err_probe` and return `err`.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-05-07  3:29 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 13:41 [PATCH 0/9] soc/tegra: pmc: Clean up legacy code Thierry Reding
2026-05-06 13:41 ` [PATCH 1/9] ata: ahci_tegra: Explicitly specify PMC instance to use Thierry Reding
2026-05-06 13:54   ` Damien Le Moal
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:41 ` [PATCH 2/9] drm/nouveau: tegra: " Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:41 ` [PATCH 3/9] drm/tegra: " Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:41 ` [PATCH 4/9] media: vde: " Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:41 ` [PATCH 5/9] PCI: tegra: " Thierry Reding
2026-05-07  3:29   ` Claude Code Review Bot [this message]
2026-05-06 13:41 ` [PATCH 6/9] usb: xhci: " Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:41 ` [PATCH 7/9] soc/tegra: pmc: Create PMC context dynamically Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:41 ` [PATCH 8/9] soc/tegra: pmc: Remove unused legacy functions Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-06 13:42 ` [PATCH 9/9] soc/tegra: pmc: Move legacy code behind CONFIG_ARM guard Thierry Reding
2026-05-07  3:29   ` Claude review: " Claude Code Review Bot
2026-05-07  3:29 ` Claude review: soc/tegra: pmc: Clean up legacy code Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch5-20260506-pmc-v1-5-a6de5da7216b@nvidia.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox