From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/syncobj: fix resource leak in drm_syncobj_import_sync_file_fence
Date: Mon, 18 May 2026 16:53:32 +1000 [thread overview]
Message-ID: <review-patch9-20260516-jorth-syncobj-v1-9-88ede9d98a81@gmail.com> (raw)
In-Reply-To: <20260516-jorth-syncobj-v1-9-88ede9d98a81@gmail.com>
Patch Review
**This is a real bug fix.** In the current upstream code:
```c
if (!chain)
return -ENOMEM; /* leaks fence and syncobj refs */
```
At line 744-745 of the current tree, if `dma_fence_chain_alloc()` fails, the function returns immediately without calling `dma_fence_put(fence)` or `drm_syncobj_put(syncobj)`.
The fix is correct. However:
- This should be submitted as a **separate standalone patch** with a `Fixes:` tag, not bundled in a feature series. It's a legitimate bug in current mainline.
- The patch could use `Fixes: <commit-hash> ("drm/syncobj: add timeline point support")` or whichever commit introduced the `point` parameter.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-18 6:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 11:06 [PATCH 00/12] misc/syncobj: add /dev/syncobj device Julian Orth
2026-05-16 11:06 ` [PATCH 01/12] drm/syncobj: add drm_syncobj_from_fd Julian Orth
2026-05-18 6:53 ` Claude review: " Claude Code Review Bot
2026-05-16 11:06 ` [PATCH 02/12] drm/syncobj: add drm_syncobj_fence_lookup Julian Orth
2026-05-18 6:53 ` Claude review: " Claude Code Review Bot
2026-05-16 11:06 ` [PATCH 03/12] drm/syncobj: make drm_syncobj_array_wait_timeout public Julian Orth
2026-05-18 6:53 ` Claude review: " Claude Code Review Bot
2026-05-16 11:06 ` [PATCH 04/12] drm/syncobj: add drm_syncobj_register_eventfd Julian Orth
2026-05-18 6:53 ` Claude review: " Claude Code Review Bot
2026-05-16 11:06 ` [PATCH 05/12] drm/syncobj: have transfer functions accept drm_syncobj directly Julian Orth
2026-05-18 6:53 ` Claude review: " Claude Code Review Bot
2026-05-16 11:06 ` [PATCH 06/12] drm/syncobj: add drm_syncobj_transfer Julian Orth
2026-05-18 6:53 ` Claude review: " Claude Code Review Bot
2026-05-16 11:06 ` [PATCH 07/12] drm/syncobj: add drm_syncobj_timeline_signal Julian Orth
2026-05-18 6:53 ` Claude review: " Claude Code Review Bot
2026-05-16 11:06 ` [PATCH 08/12] drm/syncobj: add drm_syncobj_query Julian Orth
2026-05-18 6:53 ` Claude review: " Claude Code Review Bot
2026-05-16 11:06 ` [PATCH 09/12] drm/syncobj: fix resource leak in drm_syncobj_import_sync_file_fence Julian Orth
2026-05-18 6:53 ` Claude Code Review Bot [this message]
2026-05-16 11:06 ` [PATCH 10/12] drm/syncobj: add drm_syncobj_import_sync_file Julian Orth
2026-05-18 6:53 ` Claude review: " Claude Code Review Bot
2026-05-16 11:06 ` [PATCH 11/12] drm/syncobj: add drm_syncobj_export_sync_file Julian Orth
2026-05-18 6:53 ` Claude review: " Claude Code Review Bot
2026-05-16 11:06 ` [PATCH 12/12] misc/syncobj: add new device Julian Orth
2026-05-16 11:37 ` Greg Kroah-Hartman
2026-05-16 11:38 ` Greg Kroah-Hartman
2026-05-16 12:08 ` Julian Orth
2026-05-18 6:53 ` Claude review: " Claude Code Review Bot
2026-05-18 6:53 ` Claude review: misc/syncobj: add /dev/syncobj device Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch9-20260516-jorth-syncobj-v1-9-88ede9d98a81@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox