From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/vkms: Set DRM_VBLANK_FLAG_SIMULATED
Date: Thu, 28 May 2026 12:19:16 +1000 [thread overview]
Message-ID: <review-patch9-20260527133917.207150-10-tzimmermann@suse.de> (raw)
In-Reply-To: <20260527133917.207150-10-tzimmermann@suse.de>
Patch Review
```c
- ret = drm_vblank_init(&vkms_device->drm,
- vkms_config_get_num_crtcs(config));
+ ret = drmm_vblank_init(&vkms_device->drm, vkms_config_get_num_crtcs(config),
+ DRM_VBLANK_FLAG_SIMULATED);
```
Correct — VKMS is the canonical virtual/mock KMS driver, entirely software-based.
---
**Summary:** The series is clean and well-structured. The only items worth flagging to the author:
1. Missing kerneldoc for the new `flags` field in `struct drm_vblank_crtc` (patch 1).
2. `DRM_VBLANK_FLAG_SIMULATED` starting at `BIT(1)` instead of `BIT(0)` — worth confirming this is intentional (patch 2).
All driver conversions (patches 3-9) are correct and mechanical. The UAPI change is well-justified by the discussion with compositor maintainers.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-28 2:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-27 13:32 [PATCH v2 0/9] drm: Limit DRM_IOCTL_WAIT_VBLANK to vblank interrupts Thomas Zimmermann
2026-05-27 13:32 ` [PATCH v2 1/9] drm/vblank: Add drmm_vblank_init() to indicate managed cleanup Thomas Zimmermann
2026-05-28 2:19 ` Claude review: " Claude Code Review Bot
2026-05-27 13:32 ` [PATCH v2 2/9] drm/vblank: Add DRM_VBLANK_FLAG_SIMULATED Thomas Zimmermann
2026-05-28 2:19 ` Claude review: " Claude Code Review Bot
2026-05-27 13:32 ` [PATCH v2 3/9] drm/amdgpu: vkms: Set DRM_VBLANK_FLAG_SIMULATED Thomas Zimmermann
2026-05-28 2:19 ` Claude review: " Claude Code Review Bot
2026-05-27 13:32 ` [PATCH v2 4/9] drm/bochs: " Thomas Zimmermann
2026-05-28 2:19 ` Claude review: " Claude Code Review Bot
2026-05-27 13:32 ` [PATCH v2 5/9] drm/cirrus: " Thomas Zimmermann
2026-05-28 2:19 ` Claude review: " Claude Code Review Bot
2026-05-27 13:32 ` [PATCH v2 6/9] drm/hypervdrm: " Thomas Zimmermann
2026-05-28 2:19 ` Claude review: " Claude Code Review Bot
2026-05-27 13:32 ` [PATCH v2 7/9] drm/qxl: " Thomas Zimmermann
2026-05-28 2:19 ` Claude review: " Claude Code Review Bot
2026-05-27 13:32 ` [PATCH v2 8/9] drm/virtgpu: " Thomas Zimmermann
2026-05-28 2:19 ` Claude review: " Claude Code Review Bot
2026-05-27 13:32 ` [PATCH v2 9/9] drm/vkms: " Thomas Zimmermann
2026-05-28 2:19 ` Claude Code Review Bot [this message]
2026-05-27 16:31 ` [PATCH v2 0/9] drm: Limit DRM_IOCTL_WAIT_VBLANK to vblank interrupts Julian Orth
2026-05-28 2:19 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-15 11:55 [PATCH 0/9] " Thomas Zimmermann
2026-05-15 11:55 ` [PATCH 9/9] drm/vkms: Set DRM_VBLANK_FLAG_SIMULATED Thomas Zimmermann
2026-05-15 23:20 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch9-20260527133917.207150-10-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox