From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: io_uring/rsrc: extend buffer update
Date: Tue, 05 May 2026 11:26:01 +1000 [thread overview]
Message-ID: <review-patch9-a97e2d1338029380995653824dea6bbb09d71775.1777475843.git.asml.silence@gmail.com> (raw)
In-Reply-To: <a97e2d1338029380995653824dea6bbb09d71775.1777475843.git.asml.silence@gmail.com>
Patch Review
Extends the buffer registration to support the new `io_uring_regbuf_desc` format via the `IORING_RSRC_UPDATE_EXTENDED` flag.
**UAPI concern: `IORING_RSRC_UPDATE_EXTENDED = 1U << 1`**
The flag uses bit 1 (value 2), skipping bit 0. Was `1U << 0` intentionally reserved? If not, this should be `1U << 0` for cleaner flag space usage. If so, a comment explaining what bit 0 is reserved for would be helpful.
**Repurposing `resv` field as `flags`**
```c
struct io_uring_rsrc_update2 {
__u32 offset;
- __u32 resv;
+ __u32 flags;
```
The old code checked `up.resv || up.resv2` to reject non-zero reserved fields. By renaming `resv` to `flags`, the check is relaxed — the file update path now only checks `up.flags` (and rejects non-zero), while the buffer update path accepts `IORING_RSRC_UPDATE_EXTENDED`. The `resv2` check remains. This is backward-compatible since old userspace always passed 0 for `resv`, but it's worth verifying there are no out-of-tree users relying on the `resv` rejection.
---
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-05 1:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-29 15:25 [PATCH v3 00/10] Add dmabuf read/write via io_uring Pavel Begunkov
2026-04-29 15:25 ` [PATCH v3 01/10] file: add callback for creating long-term dmabuf maps Pavel Begunkov
2026-04-30 6:03 ` Christian König
2026-04-30 18:33 ` Pavel Begunkov
2026-05-04 7:14 ` Christian König
2026-05-05 1:25 ` Claude review: " Claude Code Review Bot
2026-04-29 15:25 ` [PATCH v3 02/10] iov_iter: add iterator type for " Pavel Begunkov
2026-05-05 1:26 ` Claude review: " Claude Code Review Bot
2026-04-29 15:25 ` [PATCH v3 03/10] block: move bvec init into __bio_clone Pavel Begunkov
2026-05-05 1:26 ` Claude review: " Claude Code Review Bot
2026-04-29 15:25 ` [PATCH v3 04/10] block: introduce dma map backed bio type Pavel Begunkov
2026-05-05 1:26 ` Claude review: " Claude Code Review Bot
2026-04-29 15:25 ` [PATCH v3 05/10] lib: add dmabuf token infrastructure Pavel Begunkov
2026-05-05 1:26 ` Claude review: " Claude Code Review Bot
2026-04-29 15:25 ` [PATCH v3 06/10] block: forward create_dmabuf_token to drivers Pavel Begunkov
2026-05-05 1:26 ` Claude review: " Claude Code Review Bot
2026-04-29 15:25 ` [PATCH v3 07/10] nvme-pci: implement dma_token backed requests Pavel Begunkov
2026-04-29 15:29 ` Pavel Begunkov
2026-04-29 16:07 ` Maurizio Lombardi
2026-04-30 18:18 ` Pavel Begunkov
2026-05-05 1:26 ` Claude review: " Claude Code Review Bot
2026-04-29 15:25 ` [PATCH v3 08/10] io_uring/rsrc: introduce buf registration structure Pavel Begunkov
2026-05-05 1:26 ` Claude review: " Claude Code Review Bot
2026-04-29 15:25 ` [PATCH v3 09/10] io_uring/rsrc: extend buffer update Pavel Begunkov
2026-05-05 1:26 ` Claude Code Review Bot [this message]
2026-04-29 15:25 ` [PATCH v3 10/10] io_uring/rsrc: add dmabuf backed registered buffers Pavel Begunkov
2026-05-05 1:26 ` Claude review: " Claude Code Review Bot
2026-05-05 1:25 ` Claude review: Add dmabuf read/write via io_uring Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch9-a97e2d1338029380995653824dea6bbb09d71775.1777475843.git.asml.silence@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox