From: Aurabindo Pillai <aurabindo.pillai@amd.com>
To: Alex Hung <alex.hung@amd.com>, <harry.wentland@amd.com>,
<sunpeng.li@amd.com>, <siqueira@igalia.com>,
<alexander.deucher@amd.com>, <christian.koenig@amd.com>,
<airlied@gmail.com>, <simona@ffwll.ch>, <ray.wu@amd.com>,
<ivan.lipski@amd.com>, <srinivasan.shanmugam@amd.com>,
<marco.crivellari@suse.com>, <mario.limonciello@amd.com>,
<amd-gfx@lists.freedesktop.org>,
<dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/amd/display: Export symbols for KUnit test modules
Date: Tue, 2 Jun 2026 12:59:02 -0400 [thread overview]
Message-ID: <0bae5fea-a1d8-4516-b1a7-eb90e35c39b1@amd.com> (raw)
In-Reply-To: <20260602161536.3909009-1-alex.hung@amd.com>
On 6/2/26 12:15 PM, Alex Hung wrote:
> Add missing EXPORT_IF_KUNIT() calls for amdgpu_dm_psr_set_event,
> amdgpu_dm_ism_init, and amdgpu_dm_ism_fini so that the KUnit test
> modules can resolve these symbols when built as modules, i.e.,
> CONFIG_DRM_AMD_DC_KUNIT_TEST=m.
>
> Fixes: 7c1bb28ce2f0 ("drm/amd/display: Add KUnit tests for amdgpu_dm_psr_set_event")
> Fixes: 4db0dd9e5a63 ("drm/amd/display: Add more KUnit tests for amdgpu_dm_ism")
> Assisted-by: Copilot:Claude-Opus-4.6
> Signed-off-by: Alex Hung <alex.hung@amd.com>
> ---
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c | 2 ++
> drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c
> index 5c0841728671..32391b56097e 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_ism.c
> @@ -640,6 +640,7 @@ void amdgpu_dm_ism_init(struct amdgpu_dm_ism *ism,
> INIT_DELAYED_WORK(&ism->delayed_work, dm_ism_delayed_work_func);
> INIT_DELAYED_WORK(&ism->sso_delayed_work, dm_ism_sso_delayed_work_func);
> }
> +EXPORT_IF_KUNIT(amdgpu_dm_ism_init);
>
>
> void amdgpu_dm_ism_fini(struct amdgpu_dm_ism *ism)
> @@ -647,3 +648,4 @@ void amdgpu_dm_ism_fini(struct amdgpu_dm_ism *ism)
> cancel_delayed_work_sync(&ism->sso_delayed_work);
> cancel_delayed_work_sync(&ism->delayed_work);
> }
> +EXPORT_IF_KUNIT(amdgpu_dm_ism_fini);
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> index 85caa8534184..0dadc0bb214f 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_psr.c
> @@ -189,3 +189,4 @@ bool amdgpu_dm_psr_set_event(struct amdgpu_display_manager *dm, struct dc_stream
> return mod_power_set_psr_event(dm->power_module, stream,
> set_event, event, wait_for_disable);
> }
> +EXPORT_IF_KUNIT(amdgpu_dm_psr_set_event);
Reviewed-by: Aurabindo Pillai <aurabindo.pillai@amd.com>
next prev parent reply other threads:[~2026-06-02 16:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-02 16:15 [PATCH] drm/amd/display: Export symbols for KUnit test modules Alex Hung
2026-06-02 16:59 ` Aurabindo Pillai [this message]
2026-06-04 2:38 ` Claude review: " Claude Code Review Bot
2026-06-04 2:38 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bae5fea-a1d8-4516-b1a7-eb90e35c39b1@amd.com \
--to=aurabindo.pillai@amd.com \
--cc=airlied@gmail.com \
--cc=alex.hung@amd.com \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=harry.wentland@amd.com \
--cc=ivan.lipski@amd.com \
--cc=marco.crivellari@suse.com \
--cc=mario.limonciello@amd.com \
--cc=ray.wu@amd.com \
--cc=simona@ffwll.ch \
--cc=siqueira@igalia.com \
--cc=srinivasan.shanmugam@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox