public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: Export symbols for KUnit test modules
Date: Thu, 04 Jun 2026 12:38:58 +1000	[thread overview]
Message-ID: <review-overall-20260602161536.3909009-1-alex.hung@amd.com> (raw)
In-Reply-To: <20260602161536.3909009-1-alex.hung@amd.com>

Overall Series Review

Subject: drm/amd/display: Export symbols for KUnit test modules
Author: Alex Hung <alex.hung@amd.com>
Patches: 2
Reviewed: 2026-06-04T12:38:58.621766

---

This is a single straightforward fix patch that adds missing `EXPORT_IF_KUNIT()` calls for three functions: `amdgpu_dm_psr_set_event`, `amdgpu_dm_ism_init`, and `amdgpu_dm_ism_fini`. These exports are needed so that KUnit test modules can resolve the symbols when `CONFIG_DRM_AMD_DC_KUNIT_TEST=m`.

The patch follows the established pattern exactly — every other exported-for-KUnit function in this directory uses the same `EXPORT_IF_KUNIT()` macro from `amdgpu_dm_kunit_helpers.h`, placed immediately after the function's closing brace. Both modified files already include that header. The macro correctly expands to `EXPORT_SYMBOL()` when `CONFIG_DRM_AMD_DC_KUNIT_TEST` is enabled and to nothing otherwise, so there is no impact on non-KUnit builds.

**One observation:** The Fixes tags reference commits `7c1bb28ce2f0` ("Add KUnit tests for amdgpu_dm_psr_set_event") and `4db0dd9e5a63` ("Add more KUnit tests for amdgpu_dm_ism") which are not present in the current drm-next tree. The existing test files (`amdgpu_dm_psr_test.c` and `amdgpu_dm_ism_test.c`) on drm-next don't call any of these three functions — they test `amdgpu_dm_psr_fill_caps`, `dm_ism_next_state`, `dm_ism_get_sso_delay`, and `dm_ism_get_idle_allow_delay` instead. This patch presumably fixes those commits in a topic branch where the new tests were already added. The maintainer should confirm proper ordering so this patch lands alongside or after the commits it fixes.

**Verdict: Patch looks correct.** No functional concerns.

---

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-06-04  2:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 16:15 [PATCH] drm/amd/display: Export symbols for KUnit test modules Alex Hung
2026-06-02 16:59 ` Aurabindo Pillai
2026-06-04  2:38 ` Claude review: " Claude Code Review Bot
2026-06-04  2:38 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-overall-20260602161536.3909009-1-alex.hung@amd.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox