public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/amd/display: Export symbols for KUnit test modules
Date: Thu, 04 Jun 2026 12:38:58 +1000	[thread overview]
Message-ID: <review-patch1-20260602161536.3909009-1-alex.hung@amd.com> (raw)
In-Reply-To: <20260602161536.3909009-1-alex.hung@amd.com>

Patch Review

**Correctness: Good.** The three `EXPORT_IF_KUNIT()` additions are placed correctly — immediately after the closing brace of each function definition, consistent with all existing uses in the codebase (e.g., `amdgpu_dm_psr_fill_caps` at `amdgpu_dm_psr.c:92`, `dm_ism_next_state` at `amdgpu_dm_ism.c:131`, etc.).

**Pattern consistency:**
```c
+EXPORT_IF_KUNIT(amdgpu_dm_ism_init);
...
+EXPORT_IF_KUNIT(amdgpu_dm_ism_fini);
...
+EXPORT_IF_KUNIT(amdgpu_dm_psr_set_event);
```
All three follow the same one-liner format used throughout the directory. Both source files already have `#include "amdgpu_dm_kunit_helpers.h"`, so the macro is defined.

**Commit message:** Clear and accurate. The Fixes tags correctly identify the commits that introduced the tests needing these symbols. The `Assisted-by: Copilot:Claude-Opus-4.6` tag is noted.

**Minor nit (non-blocking):** The diff context shows a blank line between `amdgpu_dm_ism_init()` and `amdgpu_dm_ism_fini()` at the export location (lines 142-143 in the diff show two blank lines). The `EXPORT_IF_KUNIT(amdgpu_dm_ism_init)` is placed before those blank lines, while most other uses in the file place the macro right after the closing `}` with one blank line separation before the next function. This is fine — the existing code already had a double blank line there, and the macro placement is correct.

**No issues found.** The patch is minimal, correct, and follows established conventions.

---
Generated by Claude Code Patch Reviewer

      parent reply	other threads:[~2026-06-04  2:38 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-02 16:15 [PATCH] drm/amd/display: Export symbols for KUnit test modules Alex Hung
2026-06-02 16:59 ` Aurabindo Pillai
2026-06-04  2:38 ` Claude review: " Claude Code Review Bot
2026-06-04  2:38 ` Claude Code Review Bot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260602161536.3909009-1-alex.hung@amd.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox