[PATCH v4 0/3 RESEND] drm: bridge: add support for Triple 10-BIT

[PATCH v4 0/3 RESEND] drm: bridge: add support for Triple 10-BIT

[Svyatoslav Ryhel]

Triple 10-BIT LVDS Transmitter is used in Microsoft Surface RT and
MStar TSUMU88ADT3-LF-1 HDMI bridge is used in ASUS Transformer AiO
P1801-T.

Link to v3: https://lore.kernel.org/lkml/20250824092728.105643-1-clamor95@gmail.com/

---
Changes on switching from v3 to v4:
- rebased on top of v7.0

Changes on switching from v2 to v3:
- place mstar,tsumu88adt3-lf-1 alphabetically
- fix typos

Changes on switching from v1 to v2:
- sort compatible alphabetically in schema
---

David Heidelberg (1):
  dt-bindigs: display: extend the LVDS codec with Triple 10-BIT LVDS
    Transmitter

Maxim Schwalm (1):
  drm/bridge: simple-bridge: Add support for MStar TSUMU88ADT3-LF-1

Svyatoslav Ryhel (1):
  dt-bindigs: display: extend the simple bridge with MStar
    TSUMU88ADT3-LF-1 bridge

 .../devicetree/bindings/display/bridge/lvds-codec.yaml       | 1 +
 .../devicetree/bindings/display/bridge/simple-bridge.yaml    | 1 +
 drivers/gpu/drm/bridge/simple-bridge.c                       | 5 +++++
 3 files changed, 7 insertions(+)

-- 
2.51.0

[PATCH v4 1/3 RESEND] dt-bindigs: display: extend the LVDS codec with Triple 10-BIT LVDS Transmitter

[Svyatoslav Ryhel]

From: David Heidelberg <david@ixit.cz>

LVDS transmitter used in the Microsoft Surface RT.

Signed-off-by: David Heidelberg <david@ixit.cz>
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Acked-by: Rob Herring (Arm) <robh@kernel.org>
---
 Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
index 7586d681bcc6..0363201f0e61 100644
--- a/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/lvds-codec.yaml
@@ -34,6 +34,7 @@ properties:
       - items:
           - enum:
               - doestek,dtc34lm85am # For the Doestek DTC34LM85AM Flat Panel Display (FPD) Transmitter
+              - idt,v103      # For the Triple 10-BIT LVDS Transmitter
               - onnn,fin3385  # OnSemi FIN3385
               - ti,ds90c185   # For the TI DS90C185 FPD-Link Serializer
               - ti,ds90c187   # For the TI DS90C187 FPD-Link Serializer
-- 
2.51.0

[PATCH v4 2/3 RESEND] dt-bindigs: display: extend the simple bridge with MStar TSUMU88ADT3-LF-1 bridge

[Svyatoslav Ryhel]

A simple bridge used in ASUS Transformer AiO P1801-T.

Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
Reviewed-by: Robert Foss <rfoss@kernel.org>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
---
 .../devicetree/bindings/display/bridge/simple-bridge.yaml        | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
index e6808419f625..7636c24906ba 100644
--- a/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
+++ b/Documentation/devicetree/bindings/display/bridge/simple-bridge.yaml
@@ -30,6 +30,7 @@ properties:
           - algoltek,ag6311
           - asl-tek,cs5263
           - dumb-vga-dac
+          - mstar,tsumu88adt3-lf-1
           - parade,ps185hdm
           - radxa,ra620
           - realtek,rtd2171
-- 
2.51.0

[PATCH v4 3/3 RESEND] drm/bridge: simple-bridge: Add support for MStar TSUMU88ADT3-LF-1

[Svyatoslav Ryhel]

From: Maxim Schwalm <maxim.schwalm@gmail.com>

A simple HDMI bridge used in ASUS Transformer AiO P1801-T.

Signed-off-by: Maxim Schwalm <maxim.schwalm@gmail.com>
Signed-off-by: Svyatoslav Ryhel <clamor95@gmail.com>
Reviewed-by: Robert Foss <rfoss@kernel.org>
---
 drivers/gpu/drm/bridge/simple-bridge.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/gpu/drm/bridge/simple-bridge.c b/drivers/gpu/drm/bridge/simple-bridge.c
index 8aa31ca3c72d..cc13c98f9be6 100644
--- a/drivers/gpu/drm/bridge/simple-bridge.c
+++ b/drivers/gpu/drm/bridge/simple-bridge.c
@@ -270,6 +270,11 @@ static const struct of_device_id simple_bridge_match[] = {
 		.data = &(const struct simple_bridge_info) {
 			.connector_type = DRM_MODE_CONNECTOR_HDMIA,
 		},
+	}, {
+		.compatible = "mstar,tsumu88adt3-lf-1",
+		.data = &(const struct simple_bridge_info) {
+			.connector_type = DRM_MODE_CONNECTOR_HDMIA,
+		},
 	}, {
 		.compatible = "parade,ps185hdm",
 		.data = &(const struct simple_bridge_info) {
-- 
2.51.0

Claude review: drm: bridge: add support for Triple 10-BIT

[Claude Code Review Bot]

Overall Series Review

Subject: drm: bridge: add support for Triple 10-BIT
Author: Svyatoslav Ryhel <clamor95@gmail.com>
Patches: 4
Reviewed: 2026-04-12T14:40:54.330299

---

This is a clean, minimal 3-patch series adding support for two new bridge chips: the IDT V103 Triple 10-BIT LVDS Transmitter (used in Microsoft Surface RT) and the MStar TSUMU88ADT3-LF-1 HDMI bridge (used in ASUS Transformer AiO P1801-T). The changes are straightforward — just adding compatible strings to existing DT binding schemas and the simple-bridge driver. All patches follow existing patterns, alphabetical ordering is correct, and both vendor prefixes (`idt`, `mstar`) are already registered in vendor-prefixes.yaml. The series has appropriate review/ack tags from binding and bridge maintainers.

One recurring cosmetic issue: the subject prefix in patches 1 and 2 says "dt-bindigs" instead of "dt-bindings".

No functional concerns. This looks ready to merge.

---

---
Generated by Claude Code Patch Reviewer

Claude review: drm: bridge: add support for Triple 10-BIT

[Claude Code Review Bot]

Patch Review

**Author:** David Heidelberg, submitted by Svyatoslav Ryhel

Adds `idt,v103` to the lvds-codec.yaml binding schema under the encoder enum:

```yaml
              - idt,v103      # For the Triple 10-BIT LVDS Transmitter
```

**Review:**

- **Alphabetical ordering** is correct: `doestek,dtc34lm85am` → `idt,v103` → `onnn,fin3385`.
- **Vendor prefix** `idt` is registered in vendor-prefixes.yaml (line 766).
- **No driver change needed** — this entry falls under the `oneOf` clause that requires a second compatible `lvds-encoder`, so the generic lvds-encoder/lvds-codec driver handles it via the fallback compatible. This is the expected pattern.
- **Nit:** Subject says "dt-bindigs" — should be "dt-bindings". Minor typo, not a blocker.
- Has Reviewed-by from Robert Foss and Acked-by from Rob Herring.

No issues.

---

---
Generated by Claude Code Patch Reviewer

Claude review: dt-bindigs: display: extend the LVDS codec with Triple 10-BIT LVDS Transmitter

[Claude Code Review Bot]

Patch Review

**Author:** Svyatoslav Ryhel

Adds `mstar,tsumu88adt3-lf-1` to the simple-bridge.yaml binding schema:

```yaml
          - mstar,tsumu88adt3-lf-1
```

**Review:**

- **Alphabetical ordering** is correct: `dumb-vga-dac` → `mstar,tsumu88adt3-lf-1` → `parade,ps185hdm`.
- **Vendor prefix** `mstar` is registered in vendor-prefixes.yaml (line 1110).
- **Nit:** Same "dt-bindigs" typo in the subject.
- Has Reviewed-by from Robert Foss and Acked-by from Conor Dooley.
- Properly paired with patch 3/3 which adds the driver-side support. Binding-first ordering is correct.

No issues.

---

---
Generated by Claude Code Patch Reviewer

Claude review: drm/bridge: simple-bridge: Add support for MStar TSUMU88ADT3-LF-1

[Claude Code Review Bot]

Patch Review

**Author:** Maxim Schwalm, submitted by Svyatoslav Ryhel

Adds the `of_device_id` entry to the simple-bridge driver:

```c
	}, {
		.compatible = "mstar,tsumu88adt3-lf-1",
		.data = &(const struct simple_bridge_info) {
			.connector_type = DRM_MODE_CONNECTOR_HDMIA,
		},
```

**Review:**

- **Alphabetical ordering** in the match table is correct: `asl-tek,cs5263` → `mstar,tsumu88adt3-lf-1` → `parade,ps185hdm`.
- **Connector type** `DRM_MODE_CONNECTOR_HDMIA` is appropriate for an HDMI bridge, matching the cover letter description.
- **No `.timings`** field is set, which is the same pattern as other HDMI bridges in the table (e.g., `algoltek,ag6311`, `parade,ps185hdm`). The `default_bridge_timings` are only used for VGA DACs, so this is correct.
- The compound literal `&(const struct simple_bridge_info)` pattern follows the existing code exactly.
- Has Reviewed-by from Robert Foss.

No issues.

---
Generated by Claude Code Patch Reviewer