public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Bob ynn <yanlonglong@kylinos.cn>
To: dri-devel@lists.freedesktop.org
Cc: andy.yan@rock-chips.com, dmitry.baryshkov@linaro.org,
	yanlonglong <yanlonglong@kylinos.cn>
Subject: [PATCH] drm/bridge: synopsys: dw-dp: fix bool function returning negative error code
Date: Mon, 11 May 2026 14:39:41 +0800	[thread overview]
Message-ID: <20260511063941.2070-1-yanlonglong@kylinos.cn> (raw)

From: yanlonglong <yanlonglong@kylinos.cn>

The function dw_dp_video_need_vsc_sdp() is declared to return bool, but
it returns -EINVAL when dw_dp_get_bridge_state() fails. Since -EINVAL is
a non-zero value (-22), it is implicitly converted to true, which is the
opposite of the intended behavior

Fixes: 86eecc3a9c2e("drm/bridge: synopsys: Add DW DPTX Controller support library")
Signed-off-by: yanlonglong <yanlonglong@kylinos.cn>
---
 drivers/gpu/drm/bridge/synopsys/dw-dp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/bridge/synopsys/dw-dp.c b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
index 21541be094c4..7b99d91b3456 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-dp.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-dp.c
@@ -1143,7 +1143,7 @@ static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
 
 	state = dw_dp_get_bridge_state(dp);
 	if (!state)
-		return -EINVAL;
+		return false;
 
 	if (!link->vsc_sdp_supported)
 		return false;
-- 
2.43.0


             reply	other threads:[~2026-05-13  7:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  6:39 Bob ynn [this message]
2026-05-16  2:19 ` Claude review: drm/bridge: synopsys: dw-dp: fix bool function returning negative error code Claude Code Review Bot
2026-05-16  2:19 ` Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-15  2:01 [PATCH] " Bob ynn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260511063941.2070-1-yanlonglong@kylinos.cn \
    --to=yanlonglong@kylinos.cn \
    --cc=andy.yan@rock-chips.com \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox