public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: synopsys: dw-dp: fix bool function returning negative error code
Date: Sat, 16 May 2026 12:19:33 +1000	[thread overview]
Message-ID: <review-patch1-20260511063941.2070-1-yanlonglong@kylinos.cn> (raw)
In-Reply-To: <20260511063941.2070-1-yanlonglong@kylinos.cn>

Patch Review

**Bug analysis:** Correct. The function signature is:
```c
static bool dw_dp_video_need_vsc_sdp(struct dw_dp *dp)
```
The old code had:
```c
state = dw_dp_get_bridge_state(dp);
if (!state)
    return -EINVAL;
```
`-EINVAL` is `-22`, which when cast to `bool` becomes `true`. This would cause callers at lines 1163 and 1388 to incorrectly set `DP_MSA_MISC_COLOR_VSC_SDP` or take the VSC SDP code path when the bridge state couldn't be retrieved — the opposite of the intended "bail out" behavior.

**Fix assessment:** The change to `return false` is correct. When `dw_dp_get_bridge_state()` fails, the safe default is to not require a VSC SDP. Both callers treat `true` as "do extra VSC SDP work", so `false` correctly skips that path on error.

**Minor nits (non-blocking):**
- The Fixes tag formatting has a minor style issue: `Fixes: 86eecc3a9c2e("drm/bridge:...` should have a space before the parenthesis per kernel convention: `Fixes: 86eecc3a9c2e ("drm/bridge:...`
- The commit message is missing a period at the end of the description paragraph ("the opposite of the intended behavior" → "the opposite of the intended behavior.").

**Reviewed-by worthy:** Yes — this is a clear, minimal, and correct bug fix.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-16  2:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-11  6:39 [PATCH] drm/bridge: synopsys: dw-dp: fix bool function returning negative error code Bob ynn
2026-05-16  2:19 ` Claude review: " Claude Code Review Bot
2026-05-16  2:19 ` Claude Code Review Bot [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-05-15  2:01 [PATCH] " Bob ynn
2026-05-16  0:13 ` Claude review: " Claude Code Review Bot
2026-05-16  0:13 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260511063941.2070-1-yanlonglong@kylinos.cn \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox