Claude review: drm/bridge: synopsys: dw-dp: fix bool function returning negative error code

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Analysis:** The function `dw_dp_video_need_vsc_sdp()` at line 1139 returns `bool`. Before the patch, the error path at line 1145 was:

```c
if (!state)
    return -EINVAL;
```

Since `-EINVAL` is `-22`, and C implicitly converts any non-zero integer to `true` for a `bool` return, this error path was silently returning `true` — indicating a VSC SDP *is* needed, when the function actually couldn't determine the answer. The sole caller at line 1163:

```c
if (dw_dp_video_need_vsc_sdp(dp))
    misc |= DP_MSA_MISC_COLOR_VSC_SDP;
```

would incorrectly set the VSC SDP color bit in the MSA miscellaneous field on failure.

**The fix** — changing to `return false` — is correct. Returning `false` on failure is the safe default: it avoids setting the VSC SDP flag when state is unavailable, which matches the behavior of the other early-return (`!link->vsc_sdp_supported`) in the same function.

**Minor nits on the commit message:**
- The Fixes tag formatting has a minor style issue: there should be a space before the parenthesis: `Fixes: 86eecc3a9c2e ("drm/bridge:...")` (kernel convention uses `("...)`  not `("...)`). This is cosmetic but maintainers sometimes ask for it to be fixed.
- The commit message body is missing a period at the end of the sentence ("the opposite of the intended behavior" → "the opposite of the intended behavior.").

**Verdict:** The code change itself is correct and complete. No functional concerns.

---
Generated by Claude Code Patch Reviewer