From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/bridge: synopsys: dw-dp: fix bool function returning negative error code
Date: Sat, 16 May 2026 10:13:40 +1000 [thread overview]
Message-ID: <review-overall-20260515020156.601-1-yanlonglong@kylinos.cn> (raw)
In-Reply-To: <20260515020156.601-1-yanlonglong@kylinos.cn>
Overall Series Review
Subject: drm/bridge: synopsys: dw-dp: fix bool function returning negative error code
Author: Bob ynn <yanlonglong@kylinos.cn>
Patches: 1
Reviewed: 2026-05-16T10:13:40.480504
---
This is a single-patch fix for a real bug: the bool-returning function `dw_dp_video_need_vsc_sdp()` was returning `-EINVAL` (a non-zero integer) on error, which gets implicitly converted to `true`. This would incorrectly cause the VSC SDP flag (`DP_MSA_MISC_COLOR_VSC_SDP`) to be set in the MSA when `dw_dp_get_bridge_state()` fails, which is the opposite of safe/correct behavior. Returning `false` on failure is the right conservative choice — if we can't determine the bridge state, we shouldn't claim a VSC SDP is needed.
The fix is correct, minimal, and appropriate. **Recommend: Accept.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-16 0:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 2:01 [PATCH] drm/bridge: synopsys: dw-dp: fix bool function returning negative error code Bob ynn
2026-05-16 0:13 ` Claude review: " Claude Code Review Bot
2026-05-16 0:13 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-11 6:39 [PATCH] " Bob ynn
2026-05-16 2:19 ` Claude review: " Claude Code Review Bot
2026-05-16 2:19 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260515020156.601-1-yanlonglong@kylinos.cn \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox