* [PATCH] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
@ 2026-05-11 9:59 Chen-Yu Tsai
2026-05-11 14:16 ` Doug Anderson
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Chen-Yu Tsai @ 2026-05-11 9:59 UTC (permalink / raw)
To: Douglas Anderson, Neil Armstrong, Jessica Zhang,
Maarten Lankhorst, Maxime Ripard, Thomas Zimmermann
Cc: Chen-Yu Tsai, David Airlie, Simona Vetter, dri-devel,
linux-kernel
These two panels are found in MT8195 Dojo, a.k.a. the HP Chromebook
x360 13b-ca0xxx laptop.
Only the BOE entry was tested on an actual device. The AUO entry is
solely based on the provided datasheet.
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
drivers/gpu/drm/panel/panel-edp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/panel/panel-edp.c b/drivers/gpu/drm/panel/panel-edp.c
index f3cdaea89b29..98301aec2f4a 100644
--- a/drivers/gpu/drm/panel/panel-edp.c
+++ b/drivers/gpu/drm/panel/panel-edp.c
@@ -1955,6 +1955,7 @@ static const struct edp_panel_entry edp_panels[] = {
EDP_PANEL_ENTRY('A', 'U', 'O', 0xb7a9, &delay_200_500_e50, "B140HAK03.3"),
EDP_PANEL_ENTRY('A', 'U', 'O', 0xc4b4, &delay_200_500_e50, "B116XAT04.1"),
EDP_PANEL_ENTRY('A', 'U', 'O', 0xc9a8, &delay_200_500_e50, "B140QAN08.H"),
+ EDP_PANEL_ENTRY('A', 'U', 'O', 0xcb8f, &delay_200_500_e50, "B133HAN06.6"),
EDP_PANEL_ENTRY('A', 'U', 'O', 0xcdba, &delay_200_500_e50, "B140UAX01.2"),
EDP_PANEL_ENTRY('A', 'U', 'O', 0xd497, &delay_200_500_e50, "B120XAN01.0"),
EDP_PANEL_ENTRY('A', 'U', 'O', 0xf390, &delay_200_500_e50, "B140XTN07.7"),
@@ -2003,6 +2004,7 @@ static const struct edp_panel_entry edp_panels[] = {
EDP_PANEL_ENTRY('B', 'O', 'E', 0x09ae, &delay_200_500_e200, "NT140FHM-N45"),
EDP_PANEL_ENTRY('B', 'O', 'E', 0x09dd, &delay_200_500_e50, "NT116WHM-N21"),
EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a1b, &delay_200_500_e50, "NV133WUM-N63"),
+ EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a25, &delay_200_500_e50_po2e200, "NV133FHM-N4F V8.0"),
EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a36, &delay_200_500_e200, "Unknown"),
EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a3e, &delay_200_500_e80_d50, "NV116WHM-N49"),
EDP_PANEL_ENTRY('B', 'O', 'E', 0x0a5d, &delay_200_500_e50, "NV116WHM-N45"),
--
2.54.0.563.g4f69b47b94-goog
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
2026-05-11 9:59 [PATCH] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0 Chen-Yu Tsai
@ 2026-05-11 14:16 ` Doug Anderson
2026-05-16 5:39 ` Claude review: " Claude Code Review Bot
2026-05-16 5:39 ` Claude Code Review Bot
2 siblings, 0 replies; 4+ messages in thread
From: Doug Anderson @ 2026-05-11 14:16 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Neil Armstrong, Jessica Zhang, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, dri-devel,
linux-kernel
Hi,
On Mon, May 11, 2026 at 2:59 AM Chen-Yu Tsai <wenst@chromium.org> wrote:
>
> These two panels are found in MT8195 Dojo, a.k.a. the HP Chromebook
> x360 13b-ca0xxx laptop.
>
> Only the BOE entry was tested on an actual device. The AUO entry is
> solely based on the provided datasheet.
>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> drivers/gpu/drm/panel/panel-edp.c | 2 ++
> 1 file changed, 2 insertions(+)
In recent patches, we've been including the EDID in the commit
message. That helps later if someone finds that they need different
settings for the same ID. We can figure out if two panels somehow
reused the same ID or if the original timings just need updating.
-Doug
^ permalink raw reply [flat|nested] 4+ messages in thread
* Claude review: drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
2026-05-11 9:59 [PATCH] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0 Chen-Yu Tsai
2026-05-11 14:16 ` Doug Anderson
@ 2026-05-16 5:39 ` Claude Code Review Bot
2026-05-16 5:39 ` Claude Code Review Bot
2 siblings, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-05-16 5:39 UTC (permalink / raw)
To: dri-devel-reviews
Patch Review
**Sorted order — correct.** The AUO entry `0xcb8f` is correctly placed between `0xc9a8` and `0xcdba`. The BOE entry `0x0a25` is correctly placed between `0x0a1b` and `0x0a36`.
**Delay profiles — appropriate.**
The AUO entry uses `&delay_200_500_e50`, which is the standard delay profile used by nearly all surrounding AUO entries. Reasonable default for a datasheet-only entry.
The BOE entry uses `&delay_200_500_e50_po2e200`, which adds a `.powered_on_to_enable = 200` field beyond the basic `delay_200_500_e50`. This delay struct is already used by several other BOE panels (e.g., `NV133FHM-N42` at `0x0717`, `NV116WHM-N45` at `0x0754`). The choice of a delay with `powered_on_to_enable` suggests the panel needs extra time after power-on before the display can be enabled, and since this was tested on actual hardware, this is a validated choice.
**Commit message** is properly formatted and includes an honest caveat that the AUO entry is datasheet-only. The Signed-off-by is present.
**No issues.** This is a minimal, well-ordered data-only patch. Already merged to drm-next.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 4+ messages in thread
* Claude review: drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
2026-05-11 9:59 [PATCH] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0 Chen-Yu Tsai
2026-05-11 14:16 ` Doug Anderson
2026-05-16 5:39 ` Claude review: " Claude Code Review Bot
@ 2026-05-16 5:39 ` Claude Code Review Bot
2 siblings, 0 replies; 4+ messages in thread
From: Claude Code Review Bot @ 2026-05-16 5:39 UTC (permalink / raw)
To: dri-devel-reviews
Overall Series Review
Subject: drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0
Author: Chen-Yu Tsai <wenst@chromium.org>
Patches: 2
Reviewed: 2026-05-16T15:39:27.225758
---
This is a single, straightforward patch adding two new eDP panel entries to `panel-edp.c` for the HP Chromebook x360 13b-ca0xxx (MT8195 Dojo). The patch is **already merged** into drm-next (both entries are present in the current tree), which explains why it could not be applied cleanly.
The patch is clean and correct:
- Both entries are inserted in the proper sorted order by product ID within their respective manufacturer blocks.
- The delay profiles chosen are appropriate and consistent with similar panels.
- The commit message is clear and honestly notes that only the BOE panel was tested on hardware.
No issues found.
---
Generated by Claude Code Patch Reviewer
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-05-16 5:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-05-11 9:59 [PATCH] drm/panel-edp: Add AUO B133HAN06.6 and BOE NV133FHM-N4F V8.0 Chen-Yu Tsai
2026-05-11 14:16 ` Doug Anderson
2026-05-16 5:39 ` Claude review: " Claude Code Review Bot
2026-05-16 5:39 ` Claude Code Review Bot
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox