public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Jérôme de Bretagne via B4 Relay <devnull+jerome.debretagne.gmail.com@kernel.org>
To: Douglas Anderson <dianders@chromium.org>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Jessica Zhang <jesszhan0024@gmail.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	Krzysztof Kozlowski <krzk@kernel.org>,
	Jérôme de Bretagne <jerome.debretagne@gmail.com>
Subject: [PATCH 02/11] arm64: dts: qcom: sc8280xp-arcata: Enable backlight
Date: Wed, 20 May 2026 18:40:06 +0200	[thread overview]
Message-ID: <20260520-surface-sp9-5g-for-next-v1-2-9df52552bf87@gmail.com> (raw)
In-Reply-To: <20260520-surface-sp9-5g-for-next-v1-0-9df52552bf87@gmail.com>

From: Jérôme de Bretagne <jerome.debretagne@gmail.com>

Add backlight nodes and enable backlight so that it can be controlled
with the corresponding buttons found on Surface Pro Type Cover keyboards.

The nodes are almost identical to the ones from the ThinkPad X13s with
a different enable GPIO for the vreg_edp_bl node.

The difference was found by looking at the output of /sys/kernel/debug/gpio
on the ThinkPad X13s to see the properties of its enable gpio9:

  gpiochip1: GPIOs 742-751, parent: platform/c440000.spmi:pmic@1:gpio@8800, c440000.spmi:pmic@1:gpio@8800:
   ...
   gpio9 : out  high normal  vin-1 pull-down 10uA              push-pull  medium  atest-1 dtest-0
   ...

The same gpio9 on the Surface Pro 9 5G has different properties:

  gpiochip0: 10 GPIOs, parent: platform/c440000.spmi:pmic@1:gpio@8800, c440000.spmi:pmic@1:gpio@8800:
   ...
   gpio9 : in   high normal  vin-1 pull-up 30uA                push-pull  low     atest-1 dtest-0
   ...

Looking for a match on the Surface Pro 9 5G pointed to this only one:

  gpiochip2: 10 GPIOs, parent: platform/c440000.spmi:pmic@3:gpio@8800, c440000.spmi:pmic@3:gpio@8800:
   ...
   gpio6 : out  high normal  vin-1 pull-down 10uA              push-pull  medium  atest-1 dtest-0
   ...

Signed-off-by: Jérôme de Bretagne <jerome.debretagne@gmail.com>
---
 .../boot/dts/qcom/sc8280xp-microsoft-arcata.dts    | 49 ++++++++++++++++++++++
 1 file changed, 49 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
index f2b4470d4407fb5b6a3dbac8bc972c010c31bd06..14287092fb07ea15e527fd318f7ea2155448b26c 100644
--- a/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
+++ b/arch/arm64/boot/dts/qcom/sc8280xp-microsoft-arcata.dts
@@ -46,6 +46,16 @@ wcd938x: audio-codec {
 		#sound-dai-cells = <1>;
 	};
 
+	backlight: backlight {
+		compatible = "pwm-backlight";
+		pwms = <&pmc8280c_lpg 3 1000000>;
+		enable-gpios = <&pmc8280_1_gpios 8 GPIO_ACTIVE_HIGH>;
+		power-supply = <&vreg_edp_bl>;
+
+		pinctrl-0 = <&edp_bl_en>, <&edp_bl_pwm>;
+		pinctrl-names = "default";
+	};
+
 	pmic-glink {
 		compatible = "qcom,sc8280xp-pmic-glink", "qcom,pmic-glink";
 
@@ -127,6 +137,22 @@ pmic_glink_con1_sbu: endpoint {
 		};
 	};
 
+	vreg_edp_bl: regulator-edp-bl {
+		compatible = "regulator-fixed";
+
+		regulator-name = "VREG_EDP_BL";
+		regulator-min-microvolt = <3600000>;
+		regulator-max-microvolt = <3600000>;
+
+		gpio = <&pmc8280c_gpios 6 GPIO_ACTIVE_HIGH>;
+		enable-active-high;
+
+		pinctrl-0 = <&edp_bl_reg_en>;
+		pinctrl-names = "default";
+
+		regulator-boot-on;
+	};
+
 	vreg_nvme: regulator-nvme {
 		compatible = "regulator-fixed";
 
@@ -553,6 +579,10 @@ &pcie4_phy {
 	status = "okay";
 };
 
+&pmc8280c_lpg {
+	status = "okay";
+};
+
 &pmk8280_pon_pwrkey {
 	status = "okay";
 };
@@ -853,6 +883,13 @@ &lpass_tlmm {
 	status = "okay";
 };
 
+&pmc8280_1_gpios {
+	edp_bl_en: edp-bl-en-state {
+		pins = "gpio8";
+		function = "normal";
+	};
+};
+
 &pmc8280_2_gpios {
 	wwan_sw_en: wwan-sw-en-state {
 		pins = "gpio1";
@@ -860,6 +897,18 @@ wwan_sw_en: wwan-sw-en-state {
 	};
 };
 
+&pmc8280c_gpios {
+	edp_bl_pwm: edp-bl-pwm-state {
+		pins = "gpio8";
+		function = "func1";
+	};
+
+	edp_bl_reg_en: edp-bl-reg-en-state {
+		pins = "gpio6";
+		function = "normal";
+	};
+};
+
 &pmr735a_gpios {
 	hastings_reg_en: hastings-reg-en-state {
 		pins = "gpio1";

-- 
2.47.3



  parent reply	other threads:[~2026-05-20 16:40 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-20 16:40 [PATCH 00/11] Microsoft Surface Pro 9 5G update Jérôme de Bretagne via B4 Relay
2026-05-20 16:40 ` [PATCH 01/11] drm/panel: edp: Add LG LP129WT232166 panel Jérôme de Bretagne via B4 Relay
2026-05-21 16:21   ` Doug Anderson
2026-05-25 11:20   ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` Jérôme de Bretagne via B4 Relay [this message]
2026-05-20 22:26   ` [PATCH 02/11] arm64: dts: qcom: sc8280xp-arcata: Enable backlight Jérôme de Bretagne
2026-05-21  8:48     ` Konrad Dybcio
2026-05-21 17:57       ` Jérôme de Bretagne
2026-05-25 11:20   ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 03/11] arm64: dts: qcom: sc8280xp-arcata: Enable the eDP display Jérôme de Bretagne via B4 Relay
2026-05-21  8:50   ` Konrad Dybcio
2026-05-21 18:09     ` Jérôme de Bretagne
2026-05-25 11:20   ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 04/11] arm64: dts: qcom: sc8280xp-arcata: add USB-C orientation GPIOs Jérôme de Bretagne via B4 Relay
2026-05-21  8:52   ` Konrad Dybcio
2026-05-21 18:04     ` Jérôme de Bretagne
2026-05-25 11:20   ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 05/11] arm64: dts: qcom: sc8280xp-arcata: Fix top USB-C DP alt mode Jérôme de Bretagne via B4 Relay
2026-05-21  8:53   ` Konrad Dybcio
2026-05-21 17:59     ` Jérôme de Bretagne
2026-05-25 11:20   ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 06/11] arm64: dts: qcom: sc8280xp-arcata: Enable 4-lane DP support Jérôme de Bretagne via B4 Relay
2026-05-22  9:36   ` Konrad Dybcio
2026-05-25 11:20   ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 07/11] arm64: dts: qcom: sc8280xp-arcata: Add volume up/down GPIO keys Jérôme de Bretagne via B4 Relay
2026-05-21  8:54   ` Konrad Dybcio
2026-05-25 11:20   ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 08/11] arm64: dts: qcom: sc8280xp-arcata: Add lid switch Jérôme de Bretagne via B4 Relay
2026-05-21  8:54   ` Konrad Dybcio
2026-05-25 11:20   ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 09/11] arm64: dts: qcom: sc8280xp-arcata: model the PMU of the on-board wcn6855 Jérôme de Bretagne via B4 Relay
2026-05-21  8:57   ` Konrad Dybcio
2026-05-25 11:20   ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 10/11] arm64: dts: qcom: sc8280xp-arcata: Switch to uefi rtc offset Jérôme de Bretagne via B4 Relay
2026-05-21  8:57   ` Konrad Dybcio
2026-05-25 11:20   ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 11/11] arm64: dts: qcom: sc8280xp-arcata: Drop duplicate DMIC supplies Jérôme de Bretagne via B4 Relay
2026-05-21  8:58   ` Konrad Dybcio
2026-05-25 11:20   ` Claude review: " Claude Code Review Bot
2026-05-25 11:20 ` Claude review: Microsoft Surface Pro 9 5G update Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260520-surface-sp9-5g-for-next-v1-2-9df52552bf87@gmail.com \
    --to=devnull+jerome.debretagne.gmail.com@kernel.org \
    --cc=airlied@gmail.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jerome.debretagne@gmail.com \
    --cc=jesszhan0024@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=neil.armstrong@linaro.org \
    --cc=robh@kernel.org \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox