From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: arm64: dts: qcom: sc8280xp-arcata: Enable the eDP display
Date: Mon, 25 May 2026 21:20:09 +1000 [thread overview]
Message-ID: <review-patch3-20260520-surface-sp9-5g-for-next-v1-3-9df52552bf87@gmail.com> (raw)
In-Reply-To: <20260520-surface-sp9-5g-for-next-v1-3-9df52552bf87@gmail.com>
Patch Review
**Minor observation.** The eDP panel, PHY, and DP3 setup is correct and follows the X13s pattern precisely. The removal of the `regulator-always-on` FIXME comment from `vreg_l6b` is good — with the eDP PHY now properly consuming this regulator (`vdda-phy-supply = <&vreg_l6b>`), the always-on hack is no longer needed.
However, the patch also **removes `dispcc1`** enablement:
```diff
-&dispcc1 {
- status = "okay";
-};
```
The commit message doesn't mention or justify this removal. If the Surface Pro 9 5G has no outputs connected to MDSS1, this is fine, but it would be helpful to explain this in the commit message, especially since the X13s still enables dispcc1.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 11:20 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-20 16:40 [PATCH 00/11] Microsoft Surface Pro 9 5G update Jérôme de Bretagne via B4 Relay
2026-05-20 16:40 ` [PATCH 01/11] drm/panel: edp: Add LG LP129WT232166 panel Jérôme de Bretagne via B4 Relay
2026-05-21 16:21 ` Doug Anderson
2026-05-25 11:20 ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 02/11] arm64: dts: qcom: sc8280xp-arcata: Enable backlight Jérôme de Bretagne via B4 Relay
2026-05-20 22:26 ` Jérôme de Bretagne
2026-05-21 8:48 ` Konrad Dybcio
2026-05-21 17:57 ` Jérôme de Bretagne
2026-05-25 11:20 ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 03/11] arm64: dts: qcom: sc8280xp-arcata: Enable the eDP display Jérôme de Bretagne via B4 Relay
2026-05-21 8:50 ` Konrad Dybcio
2026-05-21 18:09 ` Jérôme de Bretagne
2026-05-25 11:20 ` Claude Code Review Bot [this message]
2026-05-20 16:40 ` [PATCH 04/11] arm64: dts: qcom: sc8280xp-arcata: add USB-C orientation GPIOs Jérôme de Bretagne via B4 Relay
2026-05-21 8:52 ` Konrad Dybcio
2026-05-21 18:04 ` Jérôme de Bretagne
2026-05-25 11:20 ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 05/11] arm64: dts: qcom: sc8280xp-arcata: Fix top USB-C DP alt mode Jérôme de Bretagne via B4 Relay
2026-05-21 8:53 ` Konrad Dybcio
2026-05-21 17:59 ` Jérôme de Bretagne
2026-05-25 11:20 ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 06/11] arm64: dts: qcom: sc8280xp-arcata: Enable 4-lane DP support Jérôme de Bretagne via B4 Relay
2026-05-22 9:36 ` Konrad Dybcio
2026-05-25 11:20 ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 07/11] arm64: dts: qcom: sc8280xp-arcata: Add volume up/down GPIO keys Jérôme de Bretagne via B4 Relay
2026-05-21 8:54 ` Konrad Dybcio
2026-05-25 11:20 ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 08/11] arm64: dts: qcom: sc8280xp-arcata: Add lid switch Jérôme de Bretagne via B4 Relay
2026-05-21 8:54 ` Konrad Dybcio
2026-05-25 11:20 ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 09/11] arm64: dts: qcom: sc8280xp-arcata: model the PMU of the on-board wcn6855 Jérôme de Bretagne via B4 Relay
2026-05-21 8:57 ` Konrad Dybcio
2026-05-25 11:20 ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 10/11] arm64: dts: qcom: sc8280xp-arcata: Switch to uefi rtc offset Jérôme de Bretagne via B4 Relay
2026-05-21 8:57 ` Konrad Dybcio
2026-05-25 11:20 ` Claude review: " Claude Code Review Bot
2026-05-20 16:40 ` [PATCH 11/11] arm64: dts: qcom: sc8280xp-arcata: Drop duplicate DMIC supplies Jérôme de Bretagne via B4 Relay
2026-05-21 8:58 ` Konrad Dybcio
2026-05-25 11:20 ` Claude review: " Claude Code Review Bot
2026-05-25 11:20 ` Claude review: Microsoft Surface Pro 9 5G update Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260520-surface-sp9-5g-for-next-v1-3-9df52552bf87@gmail.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox