From: Andreas Kemnade <andreas@kemnade.info>
To: maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
lumag@kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Cc: Andreas Kemnade <andreas@kemnade.info>
Subject: [PATCH] drm/connector: check if destroy function exist
Date: Thu, 21 May 2026 12:33:29 +0200 [thread overview]
Message-ID: <20260521103329.140064-1-andreas@kemnade.info> (raw)
Connectors might have not resources needed to be manually freed.
E.g. the drm_bridge_connector does not have such a callback.
Fixes: c12907be57b1 ("drm/bridge-connector: switch to using drmm allocations")
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
drivers/gpu/drm/drm_connector.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connector.c
index 47dc53c4a738..d2dfc6e8f7d0 100644
--- a/drivers/gpu/drm/drm_connector.c
+++ b/drivers/gpu/drm/drm_connector.c
@@ -198,7 +198,9 @@ static void drm_connector_free(struct kref *kref)
struct drm_device *dev = connector->dev;
drm_mode_object_unregister(dev, &connector->base);
- connector->funcs->destroy(connector);
+
+ if (connector->funcs->destroy)
+ connector->funcs->destroy(connector);
}
void drm_connector_free_work_fn(struct work_struct *work)
@@ -216,7 +218,9 @@ void drm_connector_free_work_fn(struct work_struct *work)
llist_for_each_entry_safe(connector, n, freed, free_node) {
drm_mode_object_unregister(dev, &connector->base);
- connector->funcs->destroy(connector);
+
+ if (connector->funcs->destroy)
+ connector->funcs->destroy(connector);
}
}
--
2.47.3
next reply other threads:[~2026-05-21 11:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 10:33 Andreas Kemnade [this message]
2026-05-25 10:21 ` Claude review: drm/connector: check if destroy function exist Claude Code Review Bot
2026-05-25 10:21 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260521103329.140064-1-andreas@kemnade.info \
--to=andreas@kemnade.info \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox