Claude review: drm/connector: check if destroy function exist

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Correctness: Good.**

The `drmm_connector_init()` function at line 525 of `drm_connector.c` explicitly documents and enforces that `.destroy` must be NULL:

```c
/* line 520 */ * The @drm_connector_funcs.destroy hook must be NULL.
...
/* line 533 */ if (drm_WARN_ON(dev, funcs && funcs->destroy))
                   return -EINVAL;
```

This means any connector using `drmm_connector_init()` (like `drm_bridge_connector` at `drm_bridge_connector.c:993`) will have `funcs->destroy == NULL`. Cleanup for these connectors is handled via `drmm_add_action_or_reset()` calling `drm_connector_cleanup_action()` (line 540), not through `.destroy`.

The two call sites fixed are:

1. **`drm_connector_free()` (line 194)** — the `kref` put callback:
```c
if (connector->funcs->destroy)
    connector->funcs->destroy(connector);
```

2. **`drm_connector_free_work_fn()` (line 206)** — the deferred-free worker:
```c
if (connector->funcs->destroy)
    connector->funcs->destroy(connector);
```

Both are correct. When `.destroy` is NULL, there is nothing to call — `drmm` handles the cleanup separately through the managed action.

**Minor observations:**

- The commit message subject has a minor grammatical issue: "check if destroy function exist" should be "check if destroy function exists". Trivial, not blocking.
- It might be worth also checking `connector->funcs` itself for NULL, but in practice `funcs` is always set during `drm_connector_init_only()` and should never be NULL at this point. The current check is sufficient.
- No concern about memory leaks: when `.destroy` is NULL (the `drmm` path), cleanup is already registered via `drmm_add_action_or_reset` calling `drm_connector_cleanup()`, and the memory was allocated with `drmm_kzalloc()` which is also automatically freed. Skipping `.destroy` here is the correct behavior — calling it would have been a double-free.

**Verdict: Correct, minimal, appropriate fix. The `Fixes:` tag is accurate.**

---
Generated by Claude Code Patch Reviewer