Claude review: drm/connector: check if destroy function exist

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: drm/connector: check if destroy function exist
Author: Andreas Kemnade <andreas@kemnade.info>
Patches: 1
Reviewed: 2026-05-25T20:21:15.327783

---

This is a single-patch fix for a NULL function pointer dereference in `drm_connector_free()` and `drm_connector_free_work_fn()`. The fix is correct and necessary. Connectors initialized via `drmm_connector_init()` are explicitly required to have `.destroy = NULL` (enforced by a `drm_WARN_ON` check at `drm_connector.c:533`), yet the `drm_connector_free` and `drm_connector_free_work_fn` paths unconditionally call `connector->funcs->destroy(connector)` without a NULL check. This can lead to a kernel oops when a `drmm`-managed connector's refcount drops to zero.

The fix is minimal, correct in scope, and targets the right locations. The referenced `Fixes:` tag (`c12907be57b1`) makes sense — that's when `drm_bridge_connector` was switched to `drmm` allocations, which would have introduced the possibility of reaching this code with a NULL `.destroy`.

**Verdict: Patch looks good. Recommend acceptance.**

---
Generated by Claude Code Patch Reviewer