From: Thomas Zimmermann <tzimmermann@suse.de>
To: shiyongbang@huawei.com, xinliang.liu@linaro.org,
tiantao6@hisilicon.com, kong.kongxinwei@hisilicon.com,
sumit.semwal@linaro.org, yongqin.liu@linaro.org,
jstultz@google.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, airlied@gmail.com, simona@ffwll.ch
Cc: dri-devel@lists.freedesktop.org, Thomas Zimmermann <tzimmermann@suse.de>
Subject: [PATCH v3 0/4] drm/hibmc: Fix plane helpers and convert to gem-shmem
Date: Mon, 1 Jun 2026 13:45:14 +0200 [thread overview]
Message-ID: <20260601114756.51953-1-tzimmermann@suse.de> (raw)
Convert hibmc's memory management from gem-vram ot gem-shmem. Fix a
number of bugs in preparation.
Patches 1 to 3 fix various bugs in the plane code.
Patch 4 replaces gem-vram with gem-shmem. The rational is that gem-vram
has corner cases on low-end devices and is limited in functionality. The
commit messages state a list of possible issues.
Switching to gem-shmem avoids these problems. It also enables buffer
sharing via dma_buf, which improves the hibmc driver's integration with
the overall graphics ecosystem.
We've done these changes on drivers for similar hardware, such as ast and
mgag200. Hibmc is the last of these drivers to run on gem-shmem. Gem-vram
instead is deprecated and can hopefully be removed in a later release.
Tested on an RH1288 v3 system.
v3:
- fix coding style
- rebase on display-detection fixes
v2:
- extend commit message of patch 2 (Yongbang)
- so not select TTM any longer
Thomas Zimmermann (4):
drm/hibmc: Use drm_atomic_helper_check_plane_state()
drm/hibmc: Fix list of formats on the primary plane
drm/hibmc: Do not use cpp from struct drm_format_info
drm/hibmc: Use gem-shmem with shadow-plane helpers for memory
management
drivers/gpu/drm/drm_gem_shmem_helper.c | 22 +++-
drivers/gpu/drm/hisilicon/hibmc/Kconfig | 4 +-
.../gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 110 +++++++++---------
.../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 62 +++++++---
.../gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 5 +
include/drm/drm_gem_shmem_helper.h | 4 +
6 files changed, 129 insertions(+), 78 deletions(-)
base-commit: 4f554688dffcacf48630c14f9fb77a9f60394c1c
--
2.54.0
next reply other threads:[~2026-06-01 11:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 11:45 Thomas Zimmermann [this message]
2026-06-01 11:45 ` [PATCH v3 1/4] drm/hibmc: Use drm_atomic_helper_check_plane_state() Thomas Zimmermann
2026-06-04 4:13 ` Claude review: " Claude Code Review Bot
2026-06-01 11:45 ` [PATCH v3 2/4] drm/hibmc: Fix list of formats on the primary plane Thomas Zimmermann
2026-06-04 4:13 ` Claude review: " Claude Code Review Bot
2026-06-01 11:45 ` [PATCH v3 3/4] drm/hibmc: Do not use cpp from struct drm_format_info Thomas Zimmermann
2026-06-04 4:13 ` Claude review: " Claude Code Review Bot
2026-06-01 11:45 ` [PATCH v3 4/4] drm/hibmc: Use gem-shmem with shadow-plane helpers for memory management Thomas Zimmermann
2026-06-04 4:13 ` Claude review: " Claude Code Review Bot
2026-06-04 4:13 ` Claude review: drm/hibmc: Fix plane helpers and convert to gem-shmem Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260601114756.51953-1-tzimmermann@suse.de \
--to=tzimmermann@suse.de \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jstultz@google.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=shiyongbang@huawei.com \
--cc=simona@ffwll.ch \
--cc=sumit.semwal@linaro.org \
--cc=tiantao6@hisilicon.com \
--cc=xinliang.liu@linaro.org \
--cc=yongqin.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox