From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/hibmc: Do not use cpp from struct drm_format_info
Date: Thu, 04 Jun 2026 14:13:48 +1000 [thread overview]
Message-ID: <review-patch3-20260601114756.51953-4-tzimmermann@suse.de> (raw)
In-Reply-To: <20260601114756.51953-4-tzimmermann@suse.de>
Patch Review
**Status: Good, minor nit**
Two cleanups replacing deprecated `cpp[0]` usage:
1. Line width calculation:
```c
reg = drm_format_info_min_pitch(fb->format, 0, fb->width);
```
Correct -- this is the preferred API for computing pitch from format info.
2. Format register programming:
```c
switch (fb->format->format) {
case DRM_FORMAT_XRGB8888:
reg |= HIBMC_FIELD(HIBMC_CRT_DISP_CTL_FORMAT, 2);
break;
case DRM_FORMAT_RGB565:
reg |= HIBMC_FIELD(HIBMC_CRT_DISP_CTL_FORMAT, 1);
break;
}
```
The switch has no `default` case. This is safe because `atomic_check` ensures only XRGB8888 and RGB565 reach `atomic_update`, and patch 2 restricts the format list. However, a `default: break;` or a `drm_WARN_ON_ONCE` in the default would be a minor defensive improvement. Not blocking -- this matches how other simple drivers handle it.
The absence of a Fixes/Cc:stable tag is correct since patch 2 already removed the format (RGB888) that was broken by the cpp calculation.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-06-04 4:13 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 11:45 [PATCH v3 0/4] drm/hibmc: Fix plane helpers and convert to gem-shmem Thomas Zimmermann
2026-06-01 11:45 ` [PATCH v3 1/4] drm/hibmc: Use drm_atomic_helper_check_plane_state() Thomas Zimmermann
2026-06-04 4:13 ` Claude review: " Claude Code Review Bot
2026-06-01 11:45 ` [PATCH v3 2/4] drm/hibmc: Fix list of formats on the primary plane Thomas Zimmermann
2026-06-04 4:13 ` Claude review: " Claude Code Review Bot
2026-06-01 11:45 ` [PATCH v3 3/4] drm/hibmc: Do not use cpp from struct drm_format_info Thomas Zimmermann
2026-06-04 4:13 ` Claude Code Review Bot [this message]
2026-06-01 11:45 ` [PATCH v3 4/4] drm/hibmc: Use gem-shmem with shadow-plane helpers for memory management Thomas Zimmermann
2026-06-04 4:13 ` Claude review: " Claude Code Review Bot
2026-06-04 4:13 ` Claude review: drm/hibmc: Fix plane helpers and convert to gem-shmem Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-04-20 12:09 [PATCH v2 0/4] " Thomas Zimmermann
2026-04-20 12:09 ` [PATCH v2 3/4] drm/hibmc: Do not use cpp from struct drm_format_info Thomas Zimmermann
2026-04-23 0:03 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch3-20260601114756.51953-4-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox