public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/hibmc: Use drm_atomic_helper_check_plane_state()
Date: Thu, 04 Jun 2026 14:13:48 +1000	[thread overview]
Message-ID: <review-patch1-20260601114756.51953-2-tzimmermann@suse.de> (raw)
In-Reply-To: <20260601114756.51953-2-tzimmermann@suse.de>

Patch Review

**Status: Good**

This correctly replaces the hand-rolled plane validation with the standard `drm_atomic_helper_check_plane_state()` helper. The key changes:

```c
ret = drm_atomic_helper_check_plane_state(new_plane_state, new_crtc_state,
                                          DRM_PLANE_NO_SCALING,
                                          DRM_PLANE_NO_SCALING,
                                          false, true);
```

- `can_position=false` is correct for a primary plane that must fully cover the CRTC.
- `can_update_disabled=true` is the right call -- the original code returned early when `!crtc_state->enable`, but letting the helper still initialize plane state is cleaner and safer.
- The switch from `drm_atomic_get_crtc_state()` to `drm_atomic_get_new_crtc_state()` is a subtle but correct improvement: the old call would add the CRTC to the atomic state (potentially forcing a modeset), while the new call only retrieves it if already present. `drm_atomic_helper_check_plane_state()` handles `new_crtc_state == NULL` correctly by treating the plane as not visible.
- The visibility check (`!new_plane_state->visible`) gates the stride validation below, which is correct since there's no point checking stride on an invisible plane.

The commit message is thorough and the Fixes/Cc:stable tags are appropriate.

---
Generated by Claude Code Patch Reviewer

  reply	other threads:[~2026-06-04  4:13 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-01 11:45 [PATCH v3 0/4] drm/hibmc: Fix plane helpers and convert to gem-shmem Thomas Zimmermann
2026-06-01 11:45 ` [PATCH v3 1/4] drm/hibmc: Use drm_atomic_helper_check_plane_state() Thomas Zimmermann
2026-06-04  4:13   ` Claude Code Review Bot [this message]
2026-06-01 11:45 ` [PATCH v3 2/4] drm/hibmc: Fix list of formats on the primary plane Thomas Zimmermann
2026-06-04  4:13   ` Claude review: " Claude Code Review Bot
2026-06-01 11:45 ` [PATCH v3 3/4] drm/hibmc: Do not use cpp from struct drm_format_info Thomas Zimmermann
2026-06-04  4:13   ` Claude review: " Claude Code Review Bot
2026-06-01 11:45 ` [PATCH v3 4/4] drm/hibmc: Use gem-shmem with shadow-plane helpers for memory management Thomas Zimmermann
2026-06-04  4:13   ` Claude review: " Claude Code Review Bot
2026-06-04  4:13 ` Claude review: drm/hibmc: Fix plane helpers and convert to gem-shmem Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-04-20 12:09 [PATCH v2 0/4] " Thomas Zimmermann
2026-04-20 12:09 ` [PATCH v2 1/4] drm/hibmc: Use drm_atomic_helper_check_plane_state() Thomas Zimmermann
2026-04-23  0:03   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260601114756.51953-2-tzimmermann@suse.de \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox