Re: [PATCH] drm/sched: fix NULL deref when logging missing entity runqueue

[Philipp Stanner <phasta@mailbox.org>]

On Wed, 2026-06-03 at 09:00 +0200, Christian König wrote:
> On 6/3/26 04:56, Candice Li wrote:
> > job->sched is not initialized until drm_sched_job_arm(), so use
> > pr_err() instead of dev_err(job->sched->dev, ...) when entity->rq
> > is NULL.
> 
> You need to CC the designated maintainer on stuff like that! Please use get_maintainer.pl script.

Thx, Christian

> 
> Regards,
> Christian.
> 
> > 
> > Signed-off-by: Candice Li <candice.li@amd.com>
> > ---
> >  drivers/gpu/drm/scheduler/sched_main.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> > index bd7936c03da2aa..d21eada76cedf1 100644
> > --- a/drivers/gpu/drm/scheduler/sched_main.c
> > +++ b/drivers/gpu/drm/scheduler/sched_main.c
> > @@ -806,7 +806,7 @@ int drm_sched_job_init(struct drm_sched_job *job,
> >  		 * or worse--a blank screen--leave a trail in the
> >  		 * logs, so this can be debugged easier.
> >  		 */
> > -		dev_err(job->sched->dev, "%s: entity has no rq!\n", __func__);
> > +		pr_err("*ERROR* %s: entity has no rq!\n", __func__);

I think while at it you want to remove '*ERROR*' – the pr_err etc.
markers contain the qualifiers like _err, _warn etc. so that the level
is already included for free.

Regards
P.

> >  		return -ENOENT;
> >  	}
> >