public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Christian König <christian.koenig@amd.com>
To: Candice Li <candice.li@amd.com>,
	dri-devel@lists.freedesktop.org,
	Philipp Stanner <phasta@kernel.org>
Cc: Alexander Deucher <alexander.deucher@amd.com>,
	Hawking Zhang <Hawking.Zhang@amd.com>
Subject: Re: [PATCH] drm/sched: fix NULL deref when logging missing entity runqueue
Date: Wed, 3 Jun 2026 09:00:07 +0200	[thread overview]
Message-ID: <fbac6fc1-9efe-4b62-8352-b231879cf64d@amd.com> (raw)
In-Reply-To: <20260603025636.1301481-1-candice.li@amd.com>

On 6/3/26 04:56, Candice Li wrote:
> job->sched is not initialized until drm_sched_job_arm(), so use
> pr_err() instead of dev_err(job->sched->dev, ...) when entity->rq
> is NULL.

You need to CC the designated maintainer on stuff like that! Please use get_maintainer.pl script.

Regards,
Christian.

> 
> Signed-off-by: Candice Li <candice.li@amd.com>
> ---
>  drivers/gpu/drm/scheduler/sched_main.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/scheduler/sched_main.c
> index bd7936c03da2aa..d21eada76cedf1 100644
> --- a/drivers/gpu/drm/scheduler/sched_main.c
> +++ b/drivers/gpu/drm/scheduler/sched_main.c
> @@ -806,7 +806,7 @@ int drm_sched_job_init(struct drm_sched_job *job,
>  		 * or worse--a blank screen--leave a trail in the
>  		 * logs, so this can be debugged easier.
>  		 */
> -		dev_err(job->sched->dev, "%s: entity has no rq!\n", __func__);
> +		pr_err("*ERROR* %s: entity has no rq!\n", __func__);
>  		return -ENOENT;
>  	}
>  


  parent reply	other threads:[~2026-06-03  7:00 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-03  2:56 [PATCH] drm/sched: fix NULL deref when logging missing entity runqueue Candice Li
2026-06-03  5:58 ` Tvrtko Ursulin
2026-06-03  7:00 ` Christian König [this message]
2026-06-03  7:06   ` Philipp Stanner
2026-06-03  7:10     ` Philipp Stanner
2026-06-04  1:58 ` Claude review: " Claude Code Review Bot
2026-06-04  1:58 ` Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=fbac6fc1-9efe-4b62-8352-b231879cf64d@amd.com \
    --to=christian.koenig@amd.com \
    --cc=Hawking.Zhang@amd.com \
    --cc=alexander.deucher@amd.com \
    --cc=candice.li@amd.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=phasta@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox