Claude review: drm/sched: fix NULL deref when logging missing entity runqueue

[Claude Code Review Bot <claude-review@example.com>]

Patch Review

**Bug analysis — correct:**

The commit message accurately describes the problem. In `drm_sched_job_init()`, when `entity->rq` is NULL (line 591), the code immediately tries:

```c
dev_err(job->sched->dev, "%s: entity has no rq!\n", __func__);
```

At this point `job->sched` has not been set — `job->sched` is assigned only in `drm_sched_job_arm()` (line 653). Since the function hasn't even reached the `memset(job, 0, sizeof(*job))` on line 611 yet, `job->sched` is whatever was in the caller's memory, making this a NULL or wild-pointer dereference.

**Fix — correct but has a style nit:**

```c
pr_err("*ERROR* %s: entity has no rq!\n", __func__);
```

Switching from `dev_err()` to `pr_err()` is the right approach since there's no valid device pointer available at this point.

**Nit:** The `*ERROR*` prefix is inconsistent with kernel logging conventions. `pr_err()` already logs at error level and the kernel adds the appropriate severity marker. The existing `*ERROR*` prefix on the credits check at line 601 is pre-existing code, but propagating the pattern isn't ideal. A simple `pr_err("%s: entity has no rq!\n", __func__)` or `pr_err("drm_sched: entity has no rq!\n")` would be cleaner. That said, matching the existing pattern on line 601 is defensible for consistency within this function.

**Missing Fixes tag:** Given this is a real NULL-deref crash fix, the patch should carry a `Fixes:` tag pointing to the commit that introduced the `dev_err()` call with `job->sched->dev`. This helps stable-kernel backport processes.

**Overall:** The fix is correct, minimal, and addresses a real crash. Recommend adding the `Fixes:` tag and optionally dropping the `*ERROR*` prefix.

---
Generated by Claude Code Patch Reviewer