From: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
To: 杨孙运 <yangsunyun1993@gmail.com>
Cc: syyang@lontium.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andrzej.hajda@intel.com,
neil.armstrong@linaro.org, maarten.lankhorst@linux.intel.com,
rfoss@kernel.org, mripard@kernel.org,
Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@gmail.com, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
xmzhu@lontium.corp-partner.google.com, tzimmermann@suse.de,
xbpeng@lontium.com, rlyu@lontium.com, xmzhu@lontium.com
Subject: Re: [PATCH 2/2] drm/bridge: Add LT7911EXC edp to mipi bridge driver
Date: Wed, 22 Apr 2026 21:58:13 +0300 [thread overview]
Message-ID: <3gzudodwvibrlzvzb4csbh5ljmhoxvexs4xef2jag5z7ih5nqw@ral5sgh5diso> (raw)
In-Reply-To: <CAFQXuNZXe0vXAr+dN4LQfC95pvJ5C+Z+b+AuSGZnG4Ui+Nbjww@mail.gmail.com>
On Wed, Apr 22, 2026 at 09:06:22AM +0800, 杨孙运 wrote:
> Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> 于2026年4月21日周二 19:15写道:
> >
> > On Tue, Apr 21, 2026 at 11:13:30AM +0800, 杨孙运 wrote:
> > > Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> 于2026年4月20日周一 11:57写道:
> > > >
> > > > On Mon, 20 Apr 2026 at 05:34, <syyang@lontium.com> wrote:
> > > > >
> > > > > From: Sunyun Yang <syyang@lontium.com>
> > > > > + int fw_version;
> > > > > + u32 fw_crc;
> > > > > +
> > > > > + bool enabled;
> > > >
> > > > What for?
> > > >
> > > (bool enabled;) is used as a flag in the code to reduce the frequency
> > > of power supply switching.
> >
> > How does it help to reduce the rate?
> >
> The enabled flag is used to track the hardware power state. In
> lt7911exc_pre_enable(), we check if (lt7911exc->enabled) return; to
> avoid redundant regulator enabling and reset pulses when the DRM
> framework calls pre_enable multiple times.
>
> Similarly, lt7911exc_post_disable() uses it to prevent multiple
> power-down sequences. This reduces unnecessary power supply switching
> and potential side effects.
Is there a code path leading to multiple enable or multiple disable calls?
>
> However, if you consider this optimization unnecessary, I can remove
> the flag and the related checks in the next version. Please let me
> know your preference.
>
--
With best wishes
Dmitry
next prev parent reply other threads:[~2026-04-22 18:58 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 2:33 [PATCH 0/2] Add LT7911EXC edp to mipi bridge driver syyang
2026-04-20 2:33 ` [PATCH 1/2] dt-bindings:bridge Add LT7911EXC binding syyang
2026-04-20 3:12 ` Dmitry Baryshkov
2026-04-21 1:33 ` 杨孙运
2026-04-21 11:07 ` Dmitry Baryshkov
2026-04-22 0:46 ` 杨孙运
2026-04-23 0:26 ` Claude review: " Claude Code Review Bot
2026-04-20 2:33 ` [PATCH 2/2] drm/bridge: Add LT7911EXC edp to mipi bridge driver syyang
2026-04-20 3:57 ` Dmitry Baryshkov
2026-04-21 3:13 ` 杨孙运
2026-04-21 11:15 ` Dmitry Baryshkov
2026-04-22 1:06 ` 杨孙运
2026-04-22 18:58 ` Dmitry Baryshkov [this message]
2026-04-23 0:26 ` Claude review: " Claude Code Review Bot
2026-04-20 5:05 ` Quentin Freimanis
2026-04-21 3:26 ` 杨孙运
2026-04-23 0:26 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3gzudodwvibrlzvzb4csbh5ljmhoxvexs4xef2jag5z7ih5nqw@ral5sgh5diso \
--to=dmitry.baryshkov@oss.qualcomm.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=rlyu@lontium.com \
--cc=robh@kernel.org \
--cc=syyang@lontium.com \
--cc=tzimmermann@suse.de \
--cc=xbpeng@lontium.com \
--cc=xmzhu@lontium.com \
--cc=xmzhu@lontium.corp-partner.google.com \
--cc=yangsunyun1993@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox