From: 杨孙运 <yangsunyun1993@gmail.com>
To: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Cc: syyang@lontium.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, andrzej.hajda@intel.com,
neil.armstrong@linaro.org, maarten.lankhorst@linux.intel.com,
rfoss@kernel.org, mripard@kernel.org,
Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@gmail.com, devicetree@vger.kernel.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
xmzhu@lontium.corp-partner.google.com, tzimmermann@suse.de,
rlyu@lontium.com, xbpeng@lontium.com
Subject: Re: [PATCH 1/2] dt-bindings:bridge Add LT7911EXC binding
Date: Wed, 22 Apr 2026 08:46:33 +0800 [thread overview]
Message-ID: <CAFQXuNaHLzvSKkNo+ZNxRiYMtP98php=Qa0i3r1XMDA2b16gjQ@mail.gmail.com> (raw)
In-Reply-To: <p3aruen3h3ddmzlqbdseksuqwuwvxa32qbi66yf4gjwdtb5h2a@xs3dleimg2an>
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> 于2026年4月21日周二 19:08写道:
>
> On Tue, Apr 21, 2026 at 09:33:34AM +0800, 杨孙运 wrote:
> > Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com> 于2026年4月20日周一 11:12写道:
> > >
> > > ote, your message didn't reach dri-devel. Please check why. You might
> > > need to switch to B4 Web relay submission, if there are any issues
> > > with the SMTP on your side.
> > >
> > > On Mon, 20 Apr 2026 at 05:34, <syyang@lontium.com> wrote:
> > > >
> > > > From: Sunyun Yang <syyang@lontium.com>
> > > >
> > > > -binding for lt7911exc.
> > >
> > > Less is more, but here please settle for slightly more information
> > > about the chip.
> > >
> >
> > It will be modified in the next version.
> >
> > > >
> > > > Signed-off-by: Sunyun Yang <syyang@lontium.com>
> > > > ---
> > > > .../display/bridge/lontium,lt7911exc.yaml | 91 +++++++++++++++++++
> > > > 1 file changed, 91 insertions(+)
> > > > create mode 100644 Documentation/devicetree/bindings/display/bridge/lontium,lt7911exc.yaml
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/display/bridge/lontium,lt7911exc.yaml b/Documentation/devicetree/bindings/display/bridge/lontium,lt7911exc.yaml
> > > > new file mode 100644
> > > > index 000000000000..54a73d41635a
> > > > --- /dev/null
> > > > +++ b/Documentation/devicetree/bindings/display/bridge/lontium,lt7911exc.yaml
> > > > @@ -0,0 +1,91 @@
> > > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > > > +%YAML 1.2
> > > > +---
> > > > +$id: http://devicetree.org/schemas/display/bridge/lontium,lt7911exc.yaml#
> > > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > > +
> > > > +title: Lontium LT7911EXC eDP to MIPI Bridge
> > > > +
> > > > +maintainers:
> > > > + - Sunyun Yang <syyang@lontium.com>
> > > > +
> > > > +properties:
> > > > + compatible:
> > > > + enum:
> > > > + - lontium,lt7911exc
> > > > +
> > > > + reg:
> > > > + maxItems: 1
> > > > +
> > > > + reset-gpios:
> > > > + maxItems: 1
> > > > + description: GPIO connected to RST_ pin.
> > > > +
> > > > + vdd-supply:
> > > > + description: Regulator for 1.2V MIPI phy power.
> > > > +
> > > > + vcc-supply:
> > > > + description: Regulator for 3.3V IO power.
> > > > +
> > > > + ports:
> > > > + $ref: /schemas/graph.yaml#/properties/ports
> > > > +
> > > > + properties:
> > > > + port@0:
> > > > + $ref: /schemas/graph.yaml#/properties/port
> > > > + description: Video port for mipi dsi output.
> > >
> > > MIPI, DSI
> > >
> > It will be use MIPI DSI, in the next version.
> >
> > > > +
> > > > + port@1:
> > > > + $ref: /schemas/graph.yaml#/properties/port
> > > > + description: Video port for eDP input.
> > > > +
> > > > + required:
> > > > + - port@0
> > > > + - port@1
> > > > +
> > > > +required:
> > > > + - compatible
> > > > + - reg
> > > > + - reset-gpios
> > > > + - vdd-supply
> > > > + - vcc-supply
> > > > + - ports
> > > > +
> > > > +additionalProperties: false
> > > > +
> > > > +examples:
> > > > + - |
> > > > + #include <dt-bindings/gpio/gpio.h>
> > > > + i2c {
> > > > + #address-cells = <1>;
> > > > + #size-cells = <0>;
> > > > +
> > > > + mipi-bridge@41 {
> > > > + compatible = "lontium,lt7911exc";
> > > > + reg = <0x41>;
> > > > + reset-gpios = <&gpy8 8 GPIO_ACTIVE_HIGH>;
> > >
> > > Reset pins are usually active low.
> > >
> > if reset pins use active low, lt7911exc_reset function needs to be modified to:
> > static void lt7911exc_reset(struct lt7911exc *lt7911exc)
> > {
> > gpiod_set_value_cansleep(lt7911exc->reset_gpio, 0);
> > msleep(20);
> >
> > gpiod_set_value_cansleep(lt7911exc->reset_gpio, 1);
> > msleep(20);
> >
> > gpiod_set_value_cansleep(lt7911exc->reset_gpio, 0);
> > msleep(400);
> >
> > dev_dbg(lt7911exc->dev, "lt7911exc reset");
> > }
> >
> > I think the two are essentially the same. Please confirm whether I
> > need to make the change?
>
> If the GPIO is active-low in the hardware, it should be declared so in
> DT.
>
It will use active-low in the next version.
> >
> > > > + vdd-supply = <<7911exc_1v2>;
> > > > + vcc-supply = <<7911exc_3v3>;
> > > > +
> > > > + ports {
> > > > + #address-cells = <1>;
> > > > + #size-cells = <0>;
> > > > +
> > > > + port@0 {
> > > > + reg = <0>;
> > > > +
> > > > + bridge_out: endpoint {
> > > > + remote-endpoint = <&panel_in>;
> > > > + };
> > > > + };
> > > > +
> > > > + port@1 {
> > > > + reg = <1>;
> > > > +
> > > > + bridge_in: endpoint {
> > > > + remote-endpoint = <&edp_out>;
> > > > + };
> > > > + };
> > > > + };
> > > > + };
> > > > + };
> > >
> > > --
> > > With best wishes
> > > Dmitry
>
> --
> With best wishes
> Dmitry
next prev parent reply other threads:[~2026-04-22 8:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-20 2:33 [PATCH 0/2] Add LT7911EXC edp to mipi bridge driver syyang
2026-04-20 2:33 ` [PATCH 1/2] dt-bindings:bridge Add LT7911EXC binding syyang
2026-04-20 3:12 ` Dmitry Baryshkov
2026-04-21 1:33 ` 杨孙运
2026-04-21 11:07 ` Dmitry Baryshkov
2026-04-22 0:46 ` 杨孙运 [this message]
2026-04-23 0:26 ` Claude review: " Claude Code Review Bot
2026-04-20 2:33 ` [PATCH 2/2] drm/bridge: Add LT7911EXC edp to mipi bridge driver syyang
2026-04-20 3:57 ` Dmitry Baryshkov
2026-04-21 3:13 ` 杨孙运
2026-04-21 11:15 ` Dmitry Baryshkov
2026-04-22 1:06 ` 杨孙运
2026-04-22 18:58 ` Dmitry Baryshkov
2026-04-23 0:26 ` Claude review: " Claude Code Review Bot
2026-04-20 5:05 ` Quentin Freimanis
2026-04-21 3:26 ` 杨孙运
2026-04-23 0:26 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFQXuNaHLzvSKkNo+ZNxRiYMtP98php=Qa0i3r1XMDA2b16gjQ@mail.gmail.com' \
--to=yangsunyun1993@gmail.com \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=andrzej.hajda@intel.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jernej.skrabec@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=rlyu@lontium.com \
--cc=robh@kernel.org \
--cc=syyang@lontium.com \
--cc=tzimmermann@suse.de \
--cc=xbpeng@lontium.com \
--cc=xmzhu@lontium.corp-partner.google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox