public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Michał Grzelak <michal.grzelak@intel.com>
To: "Borah, Chaitanya Kumar" <chaitanya.kumar.borah@intel.com>
Cc: Michał Grzelak <michal.grzelak@intel.com>,
	dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org,
	intel-xe@lists.freedesktop.org,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>
Subject: Re: [PATCH v1 2/2] drm/managed: fix drmm_add_mod_or_reset() kernel-doc
Date: Fri, 22 May 2026 15:40:02 +0200 (CEST)	[thread overview]
Message-ID: <676b9ad7-46f7-fabe-163e-33012a23030c@intel.com> (raw)
In-Reply-To: <8b886c39-f474-463e-99c5-2cc91466f1b9@intel.com>

[-- Attachment #1: Type: text/plain, Size: 1309 bytes --]

On Fri, 22 May 2026, Borah, Chaitanya Kumar wrote:
> On 5/21/2026 9:22 PM, Michał Grzelak wrote:
>> Kernel-doc of drmm_add_mode_or_reset() references @releases which is not
>> on argument list. Swap '@' between 'releases' and 'action' words to fix
>> the documentation.
>
> s/drmm_add_mode_or_reset/drmm_add_action
>

Title would like to see that as well...

BR,
Michał

>> 
>> Signed-off-by: Michał Grzelak <michal.grzelak@intel.com>
>> ---
>>   include/drm/drm_managed.h | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/include/drm/drm_managed.h b/include/drm/drm_managed.h
>> index 72bfac002c06..72d0d68be226 100644
>> --- a/include/drm/drm_managed.h
>> +++ b/include/drm/drm_managed.h
>> @@ -18,7 +18,7 @@ typedef void (*drmres_release_t)(struct drm_device *dev, 
>> void *res);
>>    * @action: function which should be called when @dev is released
>>    * @data: opaque pointer, passed to @action
>>    *
>> - * This function adds the @release action with optional parameter @data to 
>> the
>> + * This function adds the release @action with optional parameter @data to 
>> the
>>    * list of cleanup actions for @dev. The cleanup actions will be run in 
>> reverse
>>    * order in the final drm_dev_put() call for @dev.
>>    */
>
>

  reply	other threads:[~2026-05-22 13:40 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 15:52 [PATCH v1 0/2] fixes to DRM doc & parameter's print Michał Grzelak
2026-05-21 15:52 ` [PATCH v1 1/2] drm/print: describe 6th & 9th bit of drm.debug Michał Grzelak
2026-05-22  6:34   ` Borah, Chaitanya Kumar
2026-05-25  9:48   ` Claude review: " Claude Code Review Bot
2026-05-21 15:52 ` [PATCH v1 2/2] drm/managed: fix drmm_add_mod_or_reset() kernel-doc Michał Grzelak
2026-05-22  6:30   ` Borah, Chaitanya Kumar
2026-05-22 13:40     ` Michał Grzelak [this message]
2026-05-25  9:48   ` Claude review: " Claude Code Review Bot
2026-05-25  9:48 ` Claude review: fixes to DRM doc & parameter's print Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=676b9ad7-46f7-fabe-163e-33012a23030c@intel.com \
    --to=michal.grzelak@intel.com \
    --cc=chaitanya.kumar.borah@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox