public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/print: describe 6th & 9th bit of drm.debug
Date: Mon, 25 May 2026 19:48:10 +1000	[thread overview]
Message-ID: <review-patch1-20260521155231.1821935-2-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260521155231.1821935-2-michal.grzelak@intel.com>

Patch Review

**Correctness: Good.** The patch correctly adds the two missing bit descriptions to `MODULE_PARM_DESC`. Verified against the kernel tree:

The enum `drm_debug_category` in `include/drm/drm_print.h:98-142` defines entries in order: `DRM_UT_CORE`(0), `DRM_UT_DRIVER`(1), `DRM_UT_KMS`(2), `DRM_UT_PRIME`(3), `DRM_UT_ATOMIC`(4), `DRM_UT_VBL`(5), `DRM_UT_STATE`(6), `DRM_UT_LEASE`(7), `DRM_UT_DP`(8), `DRM_UT_DRMRES`(9). The `DECLARE_DYNDBG_CLASSMAP` at `drm_print.c:60` confirms the same order. The existing `MODULE_PARM_DESC` was indeed missing bit 6 (`STATE`) and bit 9 (`DRMRES`).

The added lines:
```
+"\t\tBit 6 (0x40)  will enable STATE messages (atomic state code)\n"
...
+"\t\tBit 9 (0x200) will enable DRMRES messages (managed resources code)");
```

These match the enum doc: `DRM_UT_STATE` is "verbose atomic state debugging" and `DRM_UT_DRMRES` is "drm managed resources code". The descriptions are consistent.

The change from `0x1ff` to `0x3ff` in `include/drm/drm_print.h:90` is also correct: with 10 categories (bits 0-9), all-bits-set is `0x3ff`, not `0x1ff` (which only covers bits 0-8). This was already wrong before `DRM_UT_DRMRES` was added — the comment was stale.

**No issues found.**

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-25  9:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-21 15:52 [PATCH v1 0/2] fixes to DRM doc & parameter's print Michał Grzelak
2026-05-21 15:52 ` [PATCH v1 1/2] drm/print: describe 6th & 9th bit of drm.debug Michał Grzelak
2026-05-22  6:34   ` Borah, Chaitanya Kumar
2026-05-25  9:48   ` Claude Code Review Bot [this message]
2026-05-21 15:52 ` [PATCH v1 2/2] drm/managed: fix drmm_add_mod_or_reset() kernel-doc Michał Grzelak
2026-05-22  6:30   ` Borah, Chaitanya Kumar
2026-05-22 13:40     ` Michał Grzelak
2026-05-25  9:48   ` Claude review: " Claude Code Review Bot
2026-05-25  9:48 ` Claude review: fixes to DRM doc & parameter's print Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-22 13:55 [PATCH v2 0/2] " Michał Grzelak
2026-05-22 13:55 ` [PATCH v2 1/2] drm/print: describe 6th & 9th bit of drm.debug Michał Grzelak
2026-05-25  8:29   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260521155231.1821935-2-michal.grzelak@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox