public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/print: describe 6th & 9th bit of drm.debug
Date: Mon, 25 May 2026 18:29:27 +1000	[thread overview]
Message-ID: <review-patch1-20260522135520.1862848-2-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260522135520.1862848-2-michal.grzelak@intel.com>

Patch Review

This patch adds the missing `Bit 6 (STATE)` and `Bit 9 (DRMRES)` entries to the `MODULE_PARM_DESC` string, and fixes the "enable all" comment from `0x1ff` to `0x3ff`.

**Correctness:** I verified against the enum `drm_debug_category` in `include/drm/drm_print.h:98-142` and the `DECLARE_DYNDBG_CLASSMAP` in `drivers/gpu/drm/drm_print.c:60-70`. There are 10 categories (bits 0–9):

| Bit | Enum | Present in MODULE_PARM_DESC? |
|-----|------|-----|
| 0–5 | CORE through VBL | Yes (already) |
| 6 | DRM_UT_STATE | **Missing → added by patch** |
| 7 | DRM_UT_LEASE | Yes (already) |
| 8 | DRM_UT_DP | Yes (already) |
| 9 | DRM_UT_DRMRES | **Missing → added by patch** |

The descriptions match the enum comments:
- `DRM_UT_STATE` → "Used for verbose atomic state debugging" → patch uses "STATE messages (atomic state code)" — consistent with the existing style.
- `DRM_UT_DRMRES` → "Used in the drm managed resources code" → patch uses "DRMRES messages (managed resources code)" — correct.

The bitmask fix from `0x1ff` (bits 0–8) to `0x3ff` (bits 0–9) is also correct, since 10 categories need 10 bits.

**Minor nit (non-blocking):** The subject says "6th & 9th bit" but the code adds "Bit 6" and "Bit 9" (0-indexed). "6th bit" in natural language would traditionally be bit 5. Consider "bit 6 & bit 9" in the subject for precision, though this is entirely cosmetic.

**Reviewed-by worthy:** Yes.

---
Generated by Claude Code Patch Reviewer

  parent reply	other threads:[~2026-05-25  8:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 13:55 [PATCH v2 0/2] fixes to DRM doc & parameter's print Michał Grzelak
2026-05-22 13:55 ` [PATCH v2 1/2] drm/print: describe 6th & 9th bit of drm.debug Michał Grzelak
2026-05-22 19:55   ` Michał Grzelak
2026-05-25  8:29   ` Claude Code Review Bot [this message]
2026-05-22 13:55 ` [PATCH v2 2/2] drm/managed: fix drmm_add_action() kernel-doc Michał Grzelak
2026-05-25  8:29   ` Claude review: " Claude Code Review Bot
2026-05-25  8:29 ` Claude review: fixes to DRM doc & parameter's print Claude Code Review Bot
  -- strict thread matches above, loose matches on Subject: below --
2026-05-21 15:52 [PATCH v1 0/2] " Michał Grzelak
2026-05-21 15:52 ` [PATCH v1 1/2] drm/print: describe 6th & 9th bit of drm.debug Michał Grzelak
2026-05-25  9:48   ` Claude review: " Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=review-patch1-20260522135520.1862848-2-michal.grzelak@intel.com \
    --to=claude-review@example.com \
    --cc=dri-devel-reviews@example.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox