From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/managed: fix drmm_add_action() kernel-doc
Date: Mon, 25 May 2026 18:29:27 +1000 [thread overview]
Message-ID: <review-patch2-20260522135520.1862848-3-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260522135520.1862848-3-michal.grzelak@intel.com>
Patch Review
This patch fixes a kernel-doc `@parameter` reference error in the `drmm_add_action()` macro documentation.
**Before:**
```c
* This function adds the @release action with optional parameter @data to the
```
**After:**
```c
* This function adds the release @action with optional parameter @data to the
```
The macro's parameters are `dev`, `action`, and `data`. The old text used `@release`, which is not a parameter — kernel-doc would flag this as an undocumented/invalid reference. The fix swaps the `@` to correctly annotate `@action` (the actual parameter) and makes `release` a plain descriptive word. This is correct.
I confirmed by reading `include/drm/drm_managed.h:15-26` — the macro is:
```c
#define drmm_add_action(dev, action, data) \
__drmm_add_action(dev, action, data, #action)
```
The parameter list is `@dev`, `@action`, `@data` — matching the corrected doc.
**Reviewed-by worthy:** Yes.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 8:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 13:55 [PATCH v2 0/2] fixes to DRM doc & parameter's print Michał Grzelak
2026-05-22 13:55 ` [PATCH v2 1/2] drm/print: describe 6th & 9th bit of drm.debug Michał Grzelak
2026-05-22 19:55 ` Michał Grzelak
2026-05-25 8:29 ` Claude review: " Claude Code Review Bot
2026-05-22 13:55 ` [PATCH v2 2/2] drm/managed: fix drmm_add_action() kernel-doc Michał Grzelak
2026-05-25 8:29 ` Claude Code Review Bot [this message]
2026-05-25 8:29 ` Claude review: fixes to DRM doc & parameter's print Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260522135520.1862848-3-michal.grzelak@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox