From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm/managed: fix drmm_add_mod_or_reset() kernel-doc
Date: Mon, 25 May 2026 19:48:11 +1000 [thread overview]
Message-ID: <review-patch2-20260521155231.1821935-3-michal.grzelak@intel.com> (raw)
In-Reply-To: <20260521155231.1821935-3-michal.grzelak@intel.com>
Patch Review
**Correctness: Good.** The existing kernel-doc at `include/drm/drm_managed.h:21` says:
```
* This function adds the @release action with optional parameter @data to the
```
The parameter is named `action`, not `release` — there is no `@release` parameter in the argument list (lines 17-18 list `@dev`, `@action`, `@data`). The fix correctly changes this to:
```
* This function adds the release @action with optional parameter @data to the
```
This is the right fix — `@action` now correctly references the documented parameter.
**Minor nit:** The commit subject says "drmm_add_mod_or_reset()" but the actual macro is `drmm_add_action` (line 25 of `drm_managed.h`). The kernel-doc comment block at line 16 is for `drmm_add_action`, not `drmm_add_action_or_reset` (which has its own doc block starting at line 32). The subject line appears to have a typo — it should say `drmm_add_action()`. The same doc issue also exists in the `drmm_add_action_or_reset` block at line 38-39 (`@release` should be `@action` there too), but that's not addressed in this patch.
**Summary:** Both patches are correct and should be applied. The only suggestion is fixing the commit subject typo in patch 2, and optionally fixing the same `@release` → `@action` issue in the `drmm_add_action_or_reset` doc block while at it.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 9:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 15:52 [PATCH v1 0/2] fixes to DRM doc & parameter's print Michał Grzelak
2026-05-21 15:52 ` [PATCH v1 1/2] drm/print: describe 6th & 9th bit of drm.debug Michał Grzelak
2026-05-22 6:34 ` Borah, Chaitanya Kumar
2026-05-25 9:48 ` Claude review: " Claude Code Review Bot
2026-05-21 15:52 ` [PATCH v1 2/2] drm/managed: fix drmm_add_mod_or_reset() kernel-doc Michał Grzelak
2026-05-22 6:30 ` Borah, Chaitanya Kumar
2026-05-22 13:40 ` Michał Grzelak
2026-05-25 9:48 ` Claude Code Review Bot [this message]
2026-05-25 9:48 ` Claude review: fixes to DRM doc & parameter's print Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260521155231.1821935-3-michal.grzelak@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox