public inbox for drm-ai-reviews@public-inbox.freedesktop.org
 help / color / mirror / Atom feed
From: Helge Deller <deller@gmx.de>
To: Thomas Zimmermann <tzimmermann@suse.de>
Cc: dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org,
	linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 0/4] fbdev: Internalize fbcon
Date: Fri, 22 May 2026 15:59:00 +0200	[thread overview]
Message-ID: <8e37cd60-4886-4018-83bc-8c6720264ecd@gmx.de> (raw)
In-Reply-To: <20260522123019.211059-1-tzimmermann@suse.de>

On 5/22/26 14:28, Thomas Zimmermann wrote:
> Turn fbcon into an internal client of fbdev. Manage all interactions
> with graphics drivers within fbdev. Add helpers for these tasks and
> convert drivers.
> 
> Fbdev's PS3 and SH-Mobile drivers update fbcon as part of user-invoked
> mode changes. Call the new helpers, which also fix inconsistencies
> among the various code paths.
> 
> Vga-switcheroo remaps the fbcon terminals when switching physical
> outputs. For now, hide this in another helper. The call will later
> move into DRM's fbdev emulation.
> 
> When all refactoring in place, fbdev manages fbcon interactions by
> itself. Remove the public interfaces.
> 
> v2:
> - use '#if defined' (Helge)
> 
> Thomas Zimmermann (4):
>    fbdev: Wrap user-invoked calls to fb_set_var() in helper
>    fbdev: Wrap user-invoked calls to fb_blank() in helper
>    fbdev: Wrap fbcon updates from vga-switcheroo in helper
>    fbdev: Do not export fbcon from fbdev
> 
>   MAINTAINERS                            |  1 -
>   drivers/gpu/vga/vga_switcheroo.c       |  6 +--
>   drivers/video/fbdev/core/fb_chrdev.c   | 12 ++----
>   drivers/video/fbdev/core/fb_internal.h |  1 +
>   drivers/video/fbdev/core/fbcon.c       |  3 --
>   drivers/video/fbdev/core/fbcon.h       | 50 +++++++++++++++++++++++
>   drivers/video/fbdev/core/fbmem.c       | 35 +++++++++++++++-
>   drivers/video/fbdev/core/fbsysfs.c     |  9 +----
>   drivers/video/fbdev/ps3fb.c            |  5 +--
>   drivers/video/fbdev/sh_mobile_lcdcfb.c |  5 +--
>   include/linux/fb.h                     |  3 ++
>   include/linux/fbcon.h                  | 55 --------------------------
>   12 files changed, 98 insertions(+), 87 deletions(-)
>   delete mode 100644 include/linux/fbcon.h

series applied to fbdev git tree.
Thanks!
Helge

  parent reply	other threads:[~2026-05-22 13:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-22 12:28 [PATCH v2 0/4] fbdev: Internalize fbcon Thomas Zimmermann
2026-05-22 12:28 ` [PATCH v2 1/4] fbdev: Wrap user-invoked calls to fb_set_var() in helper Thomas Zimmermann
2026-05-25  8:52   ` Claude review: " Claude Code Review Bot
2026-05-22 12:28 ` [PATCH v2 2/4] fbdev: Wrap user-invoked calls to fb_blank() " Thomas Zimmermann
2026-05-25  8:52   ` Claude review: " Claude Code Review Bot
2026-05-22 12:28 ` [PATCH v2 3/4] fbdev: Wrap fbcon updates from vga-switcheroo " Thomas Zimmermann
2026-05-25  8:52   ` Claude review: " Claude Code Review Bot
2026-05-22 12:28 ` [PATCH v2 4/4] fbdev: Do not export fbcon from fbdev Thomas Zimmermann
2026-05-25  8:52   ` Claude review: " Claude Code Review Bot
2026-05-22 13:59 ` Helge Deller [this message]
2026-05-25  8:52 ` Claude review: fbdev: Internalize fbcon Claude Code Review Bot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8e37cd60-4886-4018-83bc-8c6720264ecd@gmx.de \
    --to=deller@gmx.de \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox