From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: Do not export fbcon from fbdev
Date: Mon, 25 May 2026 18:52:08 +1000 [thread overview]
Message-ID: <review-patch4-20260522123019.211059-5-tzimmermann@suse.de> (raw)
In-Reply-To: <20260522123019.211059-5-tzimmermann@suse.de>
Patch Review
Moves all declarations from `include/linux/fbcon.h` into the existing internal `drivers/video/fbdev/core/fbcon.h`, adds necessary forward declarations and `#include <linux/compiler_types.h>`, then deletes the public header.
The approach of appending to the existing internal `fbcon.h` (which already has internal struct definitions and macros) is correct. The forward declarations for `struct fb_blit_caps`, `struct fb_info`, `struct fb_var_screeninfo`, and `struct fb_videomode` are needed since the internal header didn't previously include `<linux/fb.h>`.
`fbcon.c` already includes the local `"fbcon.h"` (line 85 in current tree), so dropping `<linux/fbcon.h>` (line 73) is safe — the declarations remain visible.
`fb_chrdev.c` and `fbmem.c` correctly switch from `<linux/fbcon.h>` to `"fbcon.h"`.
The `MAINTAINERS` update removing the deleted file is correct.
**No issues.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 8:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 12:28 [PATCH v2 0/4] fbdev: Internalize fbcon Thomas Zimmermann
2026-05-22 12:28 ` [PATCH v2 1/4] fbdev: Wrap user-invoked calls to fb_set_var() in helper Thomas Zimmermann
2026-05-25 8:52 ` Claude review: " Claude Code Review Bot
2026-05-22 12:28 ` [PATCH v2 2/4] fbdev: Wrap user-invoked calls to fb_blank() " Thomas Zimmermann
2026-05-25 8:52 ` Claude review: " Claude Code Review Bot
2026-05-22 12:28 ` [PATCH v2 3/4] fbdev: Wrap fbcon updates from vga-switcheroo " Thomas Zimmermann
2026-05-25 8:52 ` Claude review: " Claude Code Review Bot
2026-05-22 12:28 ` [PATCH v2 4/4] fbdev: Do not export fbcon from fbdev Thomas Zimmermann
2026-05-25 8:52 ` Claude Code Review Bot [this message]
2026-05-22 13:59 ` [PATCH v2 0/4] fbdev: Internalize fbcon Helge Deller
2026-05-25 8:52 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-27 15:14 [PATCH v3 0/4] " Thomas Zimmermann
2026-05-27 15:14 ` [PATCH v3 4/4] fbdev: Do not export fbcon from fbdev Thomas Zimmermann
2026-05-28 2:12 ` Claude review: " Claude Code Review Bot
2026-05-20 16:00 [PATCH 0/4] fbdev: Internalize fbcon Thomas Zimmermann
2026-05-20 16:00 ` [PATCH 4/4] fbdev: Do not export fbcon from fbdev Thomas Zimmermann
2026-05-25 11:30 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch4-20260522123019.211059-5-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox