From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: fbdev: Internalize fbcon
Date: Mon, 25 May 2026 18:52:07 +1000 [thread overview]
Message-ID: <review-overall-20260522123019.211059-1-tzimmermann@suse.de> (raw)
In-Reply-To: <20260522123019.211059-1-tzimmermann@suse.de>
Overall Series Review
Subject: fbdev: Internalize fbcon
Author: Thomas Zimmermann <tzimmermann@suse.de>
Patches: 6
Reviewed: 2026-05-25T18:52:07.550396
---
This is a well-structured 4-patch series from Thomas Zimmermann that internalizes fbcon as a private implementation detail of fbdev. The series creates new helper functions (`fb_set_var_from_user`, `fb_blank_from_user`, `fb_switch_outputs`) to encapsulate fbcon interactions, then moves the fbcon declarations from the public `include/linux/fbcon.h` into a private `drivers/video/fbdev/core/fbcon.h`.
The refactoring is clean and the approach is sound. The series removes exported symbols, consolidates duplicated logic, and fixes inconsistencies where some callers were missing fbcon-related steps. The Kconfig dependency of `VGA_SWITCHEROO` on `(FRAMEBUFFER_CONSOLE=n || FB=y)` justifies the `#if defined(CONFIG_FB)` guard in patch 3.
One semantic change in the `sh_mobile_lcdcfb` driver is worth noting (detailed below), though it may be intentional.
**Overall: Looks good to me with one minor observation.**
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 8:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-22 12:28 [PATCH v2 0/4] fbdev: Internalize fbcon Thomas Zimmermann
2026-05-22 12:28 ` [PATCH v2 1/4] fbdev: Wrap user-invoked calls to fb_set_var() in helper Thomas Zimmermann
2026-05-25 8:52 ` Claude review: " Claude Code Review Bot
2026-05-22 12:28 ` [PATCH v2 2/4] fbdev: Wrap user-invoked calls to fb_blank() " Thomas Zimmermann
2026-05-25 8:52 ` Claude review: " Claude Code Review Bot
2026-05-22 12:28 ` [PATCH v2 3/4] fbdev: Wrap fbcon updates from vga-switcheroo " Thomas Zimmermann
2026-05-25 8:52 ` Claude review: " Claude Code Review Bot
2026-05-22 12:28 ` [PATCH v2 4/4] fbdev: Do not export fbcon from fbdev Thomas Zimmermann
2026-05-25 8:52 ` Claude review: " Claude Code Review Bot
2026-05-22 13:59 ` [PATCH v2 0/4] fbdev: Internalize fbcon Helge Deller
2026-05-25 8:52 ` Claude Code Review Bot [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-05-27 15:14 [PATCH v3 " Thomas Zimmermann
2026-05-28 2:12 ` Claude review: " Claude Code Review Bot
2026-05-20 16:00 [PATCH 0/4] " Thomas Zimmermann
2026-05-25 11:30 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-overall-20260522123019.211059-1-tzimmermann@suse.de \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox