From: "Kandpal, Suraj" <suraj.kandpal@intel.com>
To: John Harrison <John.Harrison@Igalia.com>,
"freedreno@lists.freedesktop.org"
<freedreno@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"kernel-list@raspberrypi.com" <kernel-list@raspberrypi.com>,
"amd-gfx@lists.freedesktop.org" <amd-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"intel-xe@lists.freedesktop.org" <intel-xe@lists.freedesktop.org>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>
Subject: RE: [PATCH v4 0/7] Refactor drm_writeback_connector structure
Date: Fri, 22 May 2026 04:21:12 +0000 [thread overview]
Message-ID: <DM3PPF208195D8D4F9A49CF8335279F238BE30F2@DM3PPF208195D8D.namprd11.prod.outlook.com> (raw)
In-Reply-To: <add51789-7291-40d6-9c8a-f68f46f1f11c@Igalia.com>
> Subject: Re: [PATCH v4 0/7] Refactor drm_writeback_connector structure
>
> On 5/20/26 22:37, Suraj Kandpal wrote:
> > Some drivers cannot work with the current design where the connector
> > is embedded within the drm_writeback_connector such as intel and some
> > drivers that can get it working end up adding a lot of checks all
> > around the code to check if it's a writeback conenctor or not.
> > This is due to the inheritance limitation in C.
> > This series intends to solve it by moving the drm_writeback_connector
> > within the drm_connector and remove the drm_connector base which was
> > in drm_writeback_connector. This is done in union with hdmi connector
> > within drm_connector to save memory and since drm_connector cannot be
> > both hdmi and writeback it serves is well.
> > A RFC version was floated and discussion had taken place at [1] which
> > kicked of this more cleaner series.
> > We do all other required modifications that come with these changes
> > along with addition of new function which returns the drm_connector
> > when drm_writeback_connector is present.
> > This series also contains some writeback API cleanups as a consequence
> > of writeback connector moving into drm_connector All drivers will be
> > expected to allocate the drm_connector.
> > This discussion was tiggered from [2] and sits on top of Dmitry's
> > series see [3].
> >
> > [1] https://patchwork.freedesktop.org/series/152758/
> > [2] https://patchwork.freedesktop.org/series/152106/
> > [3] https://patchwork.freedesktop.org/series/152420/
> QQ: What tree is this patch set based on? I tried to apply it locally but I get
> conflicts no matter what baseline I use. I've tried full kernel, drm-tip and drm-
> next. Dmitry's patch set, [3] above, applies fine but I get conflicts in the rcar
> and mali files when trying to apply this set.
Hmm I probably need to take his latest revision and apply my series on top of it again then send It that should resolve it.
This should be fixed by next revision.
Regards,
Suraj Kandpal
>
> Thanks,
> John.
>
> >
> > Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
> >
> > Suraj Kandpal (7):
> > drm: writeback: Refactor drm_writeback_connector structure
> > drm: writeback: Modify writeback init helpers
> > drm: writeback: Modify drm_writeback_queue_job helper
> > drm: writeback: Modify drm_writeback_signal_completion helper
> > drm: writeback: Modify drm_writeback_get_out_fence helper
> > drm: writeback: Modify prepare_writeback_job helper
> > drm: writeback: Modify cleanup_writeback_job helper
> >
> > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 10 +--
> > .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h | 2 +-
> > .../drm/amd/display/amdgpu_dm/amdgpu_dm_wb.c | 12 +--
> > .../gpu/drm/arm/display/komeda/komeda_crtc.c | 2 +-
> > .../gpu/drm/arm/display/komeda/komeda_kms.h | 6 +-
> > .../arm/display/komeda/komeda_wb_connector.c | 11 +--
> > drivers/gpu/drm/arm/malidp_crtc.c | 2 +-
> > drivers/gpu/drm/arm/malidp_drv.h | 2 +-
> > drivers/gpu/drm/arm/malidp_mw.c | 7 +-
> > drivers/gpu/drm/drm_atomic_uapi.c | 4 +-
> > drivers/gpu/drm/drm_writeback.c | 50 +++++++-----
> > .../drm/msm/disp/dpu1/dpu_encoder_phys_wb.c | 9 ++-
> > drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.c | 10 +--
> > drivers/gpu/drm/msm/disp/dpu1/dpu_writeback.h | 4 +-
> > .../gpu/drm/renesas/rcar-du/rcar_du_crtc.h | 6 +-
> > .../drm/renesas/rcar-du/rcar_du_writeback.c | 16 ++--
> > drivers/gpu/drm/vc4/vc4_txp.c | 8 +-
> > drivers/gpu/drm/vkms/vkms_drv.h | 2 +-
> > drivers/gpu/drm/vkms/vkms_writeback.c | 15 ++--
> > include/drm/drm_connector.h | 69 ++++++++++++++++-
> > include/drm/drm_modeset_helper_vtables.h | 4 +-
> > include/drm/drm_writeback.h | 76 ++-----------------
> > 22 files changed, 164 insertions(+), 163 deletions(-)
> >
next prev parent reply other threads:[~2026-05-22 4:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 5:37 [PATCH v4 0/7] Refactor drm_writeback_connector structure Suraj Kandpal
2026-05-21 5:37 ` [PATCH v4 1/7] drm: writeback: " Suraj Kandpal
2026-05-21 23:28 ` John Harrison
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
2026-05-21 5:37 ` [PATCH v4 2/7] drm: writeback: Modify writeback init helpers Suraj Kandpal
2026-05-21 23:30 ` John Harrison
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
2026-05-21 5:37 ` [PATCH v4 3/7] drm: writeback: Modify drm_writeback_queue_job helper Suraj Kandpal
2026-05-21 23:31 ` John Harrison
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
2026-05-21 5:37 ` [PATCH v4 4/7] drm: writeback: Modify drm_writeback_signal_completion helper Suraj Kandpal
2026-05-21 23:31 ` John Harrison
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
2026-05-21 5:37 ` [PATCH v4 5/7] drm: writeback: Modify drm_writeback_get_out_fence helper Suraj Kandpal
2026-05-21 23:35 ` John Harrison
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
2026-05-21 5:37 ` [PATCH v4 6/7] drm: writeback: Modify prepare_writeback_job helper Suraj Kandpal
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
2026-05-21 5:37 ` [PATCH v4 7/7] drm: writeback: Modify cleanup_writeback_job helper Suraj Kandpal
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
2026-05-21 18:56 ` [PATCH v4 0/7] Refactor drm_writeback_connector structure John Harrison
2026-05-22 4:21 ` Kandpal, Suraj [this message]
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM3PPF208195D8D4F9A49CF8335279F238BE30F2@DM3PPF208195D8D.namprd11.prod.outlook.com \
--to=suraj.kandpal@intel.com \
--cc=John.Harrison@Igalia.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=kernel-list@raspberrypi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox