Claude review: Refactor drm_writeback_connector structure

[Claude Code Review Bot <claude-review@example.com>]

Overall Series Review

Subject: Refactor drm_writeback_connector structure
Author: Suraj Kandpal <suraj.kandpal@intel.com>
Patches: 15
Reviewed: 2026-05-25T20:57:35.484477

---

This v4 series refactors `drm_writeback_connector` by moving it from a standalone struct that *contained* a `drm_connector base` member, to instead being embedded *within* `drm_connector` itself (in a union with `drm_connector_hdmi`). This addresses a real architectural problem: drivers like Intel's that already have their own `drm_connector` subclass cannot easily embed a `drm_writeback_connector` that itself contains a `drm_connector`. The union with `hdmi` is sound since a connector cannot be both HDMI and writeback simultaneously.

The series is well-structured, splitting the refactor across logical steps: the core structural change (patch 1), then updating each helper API to take `drm_connector *` instead of `drm_writeback_connector *` (patches 2-7). Most of the mechanical conversions are correct. It has two Reviewed-by tags (Liviu Dudau, Louis Chauvet) on patch 1 and several from Dmitry Baryshkov on later patches.

However, there is **one significant bug** in patch 4 (amdgpu signal_completion change), and several minor issues across the series.

---
Generated by Claude Code Patch Reviewer