From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: drm: writeback: Modify writeback init helpers
Date: Mon, 25 May 2026 20:57:35 +1000 [thread overview]
Message-ID: <review-patch2-20260521053708.1475129-3-suraj.kandpal@intel.com> (raw)
In-Reply-To: <20260521053708.1475129-3-suraj.kandpal@intel.com>
Patch Review
Changes `drm_writeback_connector_init()` and `drmm_writeback_connector_init()` to take `struct drm_connector *` instead of `struct drm_writeback_connector *`. Clean and correct. All driver callsites are updated consistently.
**Minor issues:**
1. **Comment says "Drm connector"** — kernel convention is lowercase "DRM":
```c
* @connector: Drm connector which contains the writeback connector to initialize
```
Should be `DRM connector` or just `drm_connector`.
2. The `__drm_writeback_connector_init()` internal helper is *not* updated in this patch — it still takes `drm_writeback_connector *`. This is fine since it's static and called from the now-updated public wrappers, but it creates an inconsistency in the internal API. A follow-up could clean this up.
---
Generated by Claude Code Patch Reviewer
next prev parent reply other threads:[~2026-05-25 10:57 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-21 5:37 [PATCH v4 0/7] Refactor drm_writeback_connector structure Suraj Kandpal
2026-05-21 5:37 ` [PATCH v4 1/7] drm: writeback: " Suraj Kandpal
2026-05-21 23:28 ` John Harrison
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
2026-05-21 5:37 ` [PATCH v4 2/7] drm: writeback: Modify writeback init helpers Suraj Kandpal
2026-05-21 23:30 ` John Harrison
2026-05-25 10:57 ` Claude Code Review Bot [this message]
2026-05-21 5:37 ` [PATCH v4 3/7] drm: writeback: Modify drm_writeback_queue_job helper Suraj Kandpal
2026-05-21 23:31 ` John Harrison
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
2026-05-21 5:37 ` [PATCH v4 4/7] drm: writeback: Modify drm_writeback_signal_completion helper Suraj Kandpal
2026-05-21 23:31 ` John Harrison
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
2026-05-21 5:37 ` [PATCH v4 5/7] drm: writeback: Modify drm_writeback_get_out_fence helper Suraj Kandpal
2026-05-21 23:35 ` John Harrison
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
2026-05-21 5:37 ` [PATCH v4 6/7] drm: writeback: Modify prepare_writeback_job helper Suraj Kandpal
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
2026-05-21 5:37 ` [PATCH v4 7/7] drm: writeback: Modify cleanup_writeback_job helper Suraj Kandpal
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
2026-05-21 18:56 ` [PATCH v4 0/7] Refactor drm_writeback_connector structure John Harrison
2026-05-22 4:21 ` Kandpal, Suraj
2026-05-25 10:57 ` Claude review: " Claude Code Review Bot
-- strict thread matches above, loose matches on Subject: below --
2026-05-22 5:03 [PATCH v5 0/7] " Suraj Kandpal
2026-05-22 5:03 ` [PATCH v5 2/7] drm: writeback: Modify writeback init helpers Suraj Kandpal
2026-05-25 9:19 ` Claude review: " Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch2-20260521053708.1475129-3-suraj.kandpal@intel.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox