From: Andi Shyti <andi.shyti@kernel.org>
To: Christian König <ckoenig.leichtzumerken@gmail.com>
Cc: janusz.krzysztofik@intel.com, dri-devel@lists.freedesktop.org,
linaro-mm-sig@lists.linaro.org, linux-media@vger.kernel.org,
gaoxiang17@xiaomi.com, sumit.semwal@linaro.org
Subject: Re: [PATCH] dma-buf: fix order of trace and fput
Date: Thu, 9 Apr 2026 14:38:07 +0200 [thread overview]
Message-ID: <adedTCplYHeJPVKP@zenone.zhora.eu> (raw)
In-Reply-To: <20260408122437.1364-1-christian.koenig@amd.com>
Hi Christian,
> @@ -845,9 +845,8 @@ void dma_buf_put(struct dma_buf *dmabuf)
> if (WARN_ON(!dmabuf || !dmabuf->file))
> return;
>
> - fput(dmabuf->file);
> -
> DMA_BUF_TRACE(trace_dma_buf_put, dmabuf);
> + fput(dmabuf->file);
funny, I just found out I sent the exact same patch, just few
minutes later :-) [*]
Andi
> }
[*] https://lore.kernel.org/all/20260408123916.2604101-2-andi.shyti@kernel.org/
next prev parent reply other threads:[~2026-04-09 12:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 12:24 [PATCH] dma-buf: fix order of trace and fput Christian König
2026-04-09 12:38 ` Andi Shyti [this message]
2026-04-12 2:31 ` Claude review: " Claude Code Review Bot
2026-04-12 2:31 ` Claude Code Review Bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=adedTCplYHeJPVKP@zenone.zhora.eu \
--to=andi.shyti@kernel.org \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=gaoxiang17@xiaomi.com \
--cc=janusz.krzysztofik@intel.com \
--cc=linaro-mm-sig@lists.linaro.org \
--cc=linux-media@vger.kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox