From: Claude Code Review Bot <claude-review@example.com>
To: dri-devel-reviews@example.com
Subject: Claude review: dma-buf: fix order of trace and fput
Date: Sun, 12 Apr 2026 12:31:05 +1000 [thread overview]
Message-ID: <review-patch1-20260408122437.1364-1-christian.koenig@amd.com> (raw)
In-Reply-To: <20260408122437.1364-1-christian.koenig@amd.com>
Patch Review
**The bug (confirmed):** The `DMA_BUF_TRACE` macro (defined at `drivers/dma-buf/dma-buf.c:47`) acquires `dmabuf->name_lock` and then the tracepoint itself accesses `dmabuf->exp_name`, `dmabuf->size`, and `dmabuf->file->f_inode->i_ino`. Calling this after `fput()` is a use-after-free if that `fput()` drops the last reference, since the file's release callback will free the dma-buf.
**The fix is correct:**
```diff
- fput(dmabuf->file);
-
DMA_BUF_TRACE(trace_dma_buf_put, dmabuf);
+ fput(dmabuf->file);
```
Moving the trace before `fput()` ensures the dmabuf and its file are still alive when the tracepoint accesses their fields. The `WARN_ON(!dmabuf || !dmabuf->file)` guard above already validates both pointers before we reach this code.
**Tag issue:** The commit message uses `Fixed:` but the standard kernel tag is `Fixes:` (with an 's'). This should be corrected:
```
Fixed: 281a22631423 ("dma-buf: add some tracepoints to debug.")
```
should be:
```
Fixes: 281a22631423 ("dma-buf: add some tracepoints to debug.")
```
Scripts like `scripts/checkpatch.pl` and automated stable-kernel backport tooling rely on the `Fixes:` tag being spelled correctly.
**Minor note:** The commit message says "Only compile tested!" — this is appreciated transparency, but given how straightforward the reordering is, the fix is clearly correct by inspection. The tracepoint just needs to read fields before they're potentially freed; there's no subtle ordering dependency in the other direction (the trace doesn't need to observe post-fput state).
**Verdict:** The fix itself is good — one clear use-after-free fixed with a minimal, obviously-correct reordering. Just fix `Fixed:` → `Fixes:` before applying.
---
Generated by Claude Code Patch Reviewer
prev parent reply other threads:[~2026-04-12 2:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-08 12:24 [PATCH] dma-buf: fix order of trace and fput Christian König
2026-04-09 12:38 ` Andi Shyti
2026-04-12 2:31 ` Claude review: " Claude Code Review Bot
2026-04-12 2:31 ` Claude Code Review Bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=review-patch1-20260408122437.1364-1-christian.koenig@amd.com \
--to=claude-review@example.com \
--cc=dri-devel-reviews@example.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox